[jboss-jira] [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use

[Randall Hauch (JIRA)]

    [ https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690537#comment-12690537 ] 

Randall Hauch edited comment on AS7-4713 at 5/4/12 4:02 PM:
------------------------------------------------------------

One concern I have with this is that it changes the class loader used to load the {{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the {{classForName(...)}} method:

* {{classForName(String,Class)}} attempts to load the named class using the thread's current context class loader or, if that fails, with the class loader used to load the specified class.
* {{classForName(String))}} attempts to load the named class using the thread's current context class loader or, if that fails, with the class loader used to load the *_the ReflectHelper class_*.

The behavior of invocations of the first form shouldn't change, since the caller is supplying the class loader. However, invocations of the second form will experience different behavior. With this change, the ReflectClass will not be in the same class loader as Hibernate Core.
                
      was (Author: rhauch):
    One concern I have with this is that it changes the class loader used to load the {{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the {{classForName(...)}} method:

* {{classForName(String,Class)}} attempts to load the named class using the thread's current context class loader or, if that fails, with the class loader used to load the specified class.
* {{classForName(String))}} attempts to load the named class using the thread's current context class loader or, if that fails, with the class loader used to load the **__the ReflectHelper class__**.

The behavior of invocations of the first form shouldn't change, since the caller is supplying the class loader. However, invocations of the second form will experience different behavior. With this change, the ReflectClass will not be in the same class loader as Hibernate Core.
                  
> Move hibernate-commons-annotations into a separate module that hibernate search can also use
> --------------------------------------------------------------------------------------------
>
>                 Key: AS7-4713
>                 URL: https://issues.jboss.org/browse/AS7-4713
>             Project: Application Server 7
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Sanne Grinovero
>            Assignee: Scott Marlow
>             Fix For: 7.1.2.Final (EAP)
>
>
> This jar file is used by several other projects which don't need Hibernate as a dependency; if we don't split it we will either have duplicate jars, (and in the case of Hibernate Search even possible conflicts) or all these modules will need to include Hibernate, getting then bound to a specific version for a long time (while support times don't match).
> As a welcome side-effect, applications depending on Hibernate won't be able to see this module, which is a good thing as this is not intended to be a public API.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira