[jboss-jira] [JBoss JIRA] (AS7-4603) Controller incorrectly reports missing service dependencies

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690646#comment-12690646 ] 

Brian Stansberry commented on AS7-4603:
---------------------------------------

Yes, it's possible. The OperationContext impl generates a report of missing/failed services at the beginning of Stage.VERIFY. This report is used to check if any service removal done by the operation triggered a missing service. The report is then cached until on the return path (after verification is complete, configuration is persisted or rollback is performed) the exclusive operation lock is released. At that point the cached report is output.

So it's possible in that interim period the stuff done by OSGi's listener could have resolved the failure condition.

I'll look into how best to improve that in the morning. There will however still be a race here, since it's possible the thread that does all of the above will do it all and print the report before OSGi's listener installs the COMPLETE service. My guess though is the OSGi listener stuff will usually win the race, since all it has to do is install a service (not have it fully start) while the operation thread needs to do verification, persist the model etc. 
                
> Controller incorrectly reports missing service dependencies
> -----------------------------------------------------------
>
>                 Key: AS7-4603
>                 URL: https://issues.jboss.org/browse/AS7-4603
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: OSGi, Server
>            Reporter: Thomas Diesler
>            Assignee: Brian Stansberry
>             Fix For: 7.1.2.Final (EAP)
>
>
> On OSGi subsystem activation the server may report missing/unsatisfied dependencies.
> However, that service is in fact installed and active. Otherwise, the framework would not initialize let alone start.
> {code}
> 12:48:39,952 INFO  [org.jboss.osgi.framework] (MSC service thread 1-1) JBOSGI011004: JBossOSGi Framework Core - 1.3.0.CR9
> 12:48:41,036 INFO  [org.jboss.osgi.framework] (MSC service thread 1-4) JBOSGI011009: Starting bundles for start level: 1
> 12:48:41,039 INFO  [org.jboss.osgi.framework] (MSC service thread 1-4) JBOSGI011001: Bundle started: osgi.enterprise:4.2.0.201003190513
> 12:48:41,041 INFO  [org.jboss.osgi.framework] (MSC service thread 1-4) JBOSGI011001: Bundle started: javax.servlet.api:2.5.0.Final
> 12:48:41,060 INFO  [org.jboss.osgi.framework] (MSC service thread 1-4) JBOSGI011001: Bundle started: jboss-osgi-logging:1.0.0
> 12:48:41,072 INFO  [org.jboss.osgi.framework] (MSC service thread 1-4) JBOSGI011001: Bundle started: jboss-as-osgi-configadmin:7.1.2.Final-SNAPSHOT
> 12:48:41,074 INFO  [org.jboss.osgi.framework] (MSC service thread 1-4) JBOSGI011000: OSGi Framework started
> 12:48:41,352 INFO  [org.jboss.as.server] (management-handler-thread - 2) JBAS018559: Deployed "foo"
> 12:48:41,353 INFO  [org.jboss.as.controller] (management-handler-thread - 2) JBAS014774: Service status report
> JBAS014775:    New missing/unsatisfied dependencies:
>       service jbosgi.integration.AutoInstallHandler.COMPLETE (missing) dependents: [service jbosgi.integration.PersistentBundlesHandler, service jbosgi.framework.INIT] 
> {code}
> A possible source of the issue is that the service in question (jbosgi.integration.AutoInstallHandler.COMPLETE) gets added by a listener and is not part of the normal service dependency chain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira