[jboss-jira] [JBoss JIRA] (JGRP-1461) SEQUENCER leaks sequence numbers

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12691666#comment-12691666 ] 

Bela Ban commented on JGRP-1461:
--------------------------------

[Copied from 1458]
I think that when SeqnoTable.add() creates a new Entry, it always creates Entry(0) (because SeqnoTable.next_to_receive is always 0). Is that true? and if so, is it correct?

A might join a group long after some other member B has already broadcast the messages with sequence numbers 0,1,2, say. Then since A will never receive those messages, isn't it going to end up with an Entry for B in which the Set of seqnos just grows indefinitely?

It looks to me as though maybe when it creates a new entry it should do so with Entry(seqno) rather than Entry(next_to_receive). Or have I misunderstood something?
                
> SEQUENCER leaks sequence numbers
> --------------------------------
>
>                 Key: JGRP-1461
>                 URL: https://issues.jboss.org/browse/JGRP-1461
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 3.0.9, 3.1
>            Reporter: David Hotham
>            Assignee: Bela Ban
>             Fix For: 3.0.10, 3.1
>
>
> As noted in JGRP-1458, it looks as though SEQUENCER always thinks that sequence numbers must start at zero.  But a member who joins a group after some messages have already been broadcast may never receive sequence number zero.  So, I think, his SeqnoTable will grow indefinitely.
> Note that this one's mostly through code reading.  I think I'm right; but I'm happy to be told otherwise!
> Pull request to follow shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira