[jboss-jira] [JBoss JIRA] (JGRP-1461) SEQUENCER leaks sequence numbers

[Bela Ban (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban reopened JGRP-1461:
----------------------------



We *do* have to check for dupes:
- D sends messages 5,7,6 (sent by different threads) to A
- A broadcasts 5,7,6, but only A, B and C get them (not D)
- A crashes, B becomes coord
- D re-forwards 5,7,6 to B
- B broadcasts 5,7,6: B and C get duplicates !

SOLUTION: keep the last N messages in a set, and if  a seqno is in the set, drop the message (dupe)
                
> SEQUENCER leaks sequence numbers
> --------------------------------
>
>                 Key: JGRP-1461
>                 URL: https://issues.jboss.org/browse/JGRP-1461
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 3.0.9, 3.1
>            Reporter: David Hotham
>            Assignee: Bela Ban
>             Fix For: 3.0.10, 3.1
>
>
> As noted in JGRP-1458, it looks as though SEQUENCER always thinks that sequence numbers must start at zero.  But a member who joins a group after some messages have already been broadcast may never receive sequence number zero.  So, I think, his SeqnoTable will grow indefinitely.
> Note that this one's mostly through code reading.  I think I'm right; but I'm happy to be told otherwise!
> Pull request to follow shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira