[jboss-jira] [JBoss JIRA] (JGRP-1466) TP: unicast messages are not looped back when using a shared transport

[Bela Ban (JIRA)]

Bela Ban created JGRP-1466:
------------------------------

             Summary: TP: unicast messages are not looped back when using a shared transport
                 Key: JGRP-1466
                 URL: https://issues.jboss.org/browse/JGRP-1466
             Project: JGroups
          Issue Type: Bug
            Reporter: Bela Ban
            Assignee: Bela Ban
             Fix For: 3.0.11, 3.1


In TP.down, we have the following code:
if(loopback && (multicast || (dest.equals(msg.getSrc()) && dest.equals(local_addr)))) {
   // loop back
   return;
}
send(msg)


If loopback=true and !multicast, we still never loop back a unicast message as local_addr will always be false when we use a shared transport (singleton_name != null).

SOLUTION:
Drop the last part of the if-clause:
if(loopback && (multicast || (dest.equals(msg.getSrc()))))

This is in down(), so msg.getSrc() can only be sent by the local member, so the last part is not needed.

Note that this issue doesn't cause erroneous behavior, but unnecessarily sends a unicast message to self, where it could have been looped back.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira