[jboss-jira] [JBoss JIRA] (AS7-5008) host-controller module does parse command line args too late

[Bernd Eckenfels (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732563#comment-12732563 ] 

Bernd Eckenfels commented on AS7-5008:
--------------------------------------

I sent a Pull request which removes the -v/-h parsing code. It also removes the usage() output and fixed one occurence where command line errors are written to .out instead of .err:

https://github.com/jbossas/jboss-as/pull/3412

However while working on this I noticed that there are still some inconsitencies:

- not all parsing errors write helpfull messages to stderr - is it needed nowhere or everywhere?
- the abort() function seems to have inconsistent usage, what error code should be returned on parsing errors? (even in some places System.exit() is used instead of abort())

Let me know in what direction you want the code to be reworked, glad to help here.


                
> host-controller module does parse command line args too late
> ------------------------------------------------------------
>
>                 Key: AS7-5008
>                 URL: https://issues.jboss.org/browse/AS7-5008
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 7.1.1.Final, 7.2.0.Alpha1
>            Reporter: Bernd Eckenfels
>            Assignee: Brian Stansberry
>            Priority: Minor
>              Labels: as, usage
>
> When starting the host controller module to use the -v or -h command line switches (which are supported in the code) there will be no result. The reason for this is, that the host-controller reads the authKey before it parses the command line for the manual invok. Also it looks like the redirected input/output leads to the case that no usage() can be writte anyway.
> org.jboss.as.process.protocol.StreamUtils.readFully(StreamUtils.java:124)
> org.jboss.as.host.controller.Main.main(Main.java:82)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> java.lang.reflect.Method.invoke(Unknown Source)
> org.jboss.modules.Module.run(Module.java:260)
> org.jboss.modules.Main.main(Main.java:291)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira