[jboss-jira] [JBoss JIRA] (AS7-5929) :reload operation clears up the restart-required process-state

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737388#comment-12737388 ] 

Brian Stansberry commented on AS7-5929:
---------------------------------------

Your change in transition() doesn't work because it gets overwritten. AbstractControllerService.start() will run after the rootService is up. And it starts the "Controller Boot Thread". And at the end of it's run() it calls processState.setRunning().

It could work if ControlledProcessState.setRunning() would only transition to State.RUNNING if the current state was State.STARTING. But I'm concerned that having the state be RESTART_REQUIRED instead of STARTING all through the boot could break things.

I don't understand why you posted the bit from setRestartRequired(). It looks like the existing code.
                
> :reload operation clears up the restart-required process-state
> --------------------------------------------------------------
>
>                 Key: AS7-5929
>                 URL: https://issues.jboss.org/browse/AS7-5929
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 7.1.3.Final (EAP)
>            Reporter: Jeff Mesnil
>            Assignee: Bartosz Baranowski
>
> For the patching service, the patch command leaves the server in a restart-required state
> {noformat}
> [standalone at localhost:9999 /] patch /home/jmesnil/Developer/jboss-as/build/target/jboss-as-7.2.0.Alpha1-SNAPSHOT/patch.zip
> {
>     "outcome" : "success",
>     "response-headers" : {
>         "operation-requires-restart" : true,
>         "process-state" : "restart-required"
>     }
> }
> {noformat}
> If I try to change the AS7 configuration, the CLI warns me that a restart is required, for example:
> {noformat}
> [standalone at localhost:9999 hornetq-server=default] ./queue=foo:add(queue-address=foo)
> {
>     "outcome" => "success",
>     "response-headers" => {"process-state" => "restart-required"}
> }
> {noformat}
> However, when I reload the server using the /:reload command, the process-state header is cleared out:
> {noformat}
> [standalone at localhost:9999 hornetq-server=default] /:reload
> {"outcome" => "success"}
> [standalone at localhost:9999 hornetq-server=default] ./queue=bar:add(queue-address=bar)
> {"outcome" => "success"}
> {noformat}
> This is not correct: until the server is restarted (not reloaded), the result of my patch operation will not be taken into account (eg changing the AS7 module path).
> Reloading the server should not clear its process-state if it is set to "restart-required"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira