[jboss-jira] [JBoss JIRA] (JBJCA-902) Unwanted config properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter

[Stefano Maestri (JIRA)]

     [ https://issues.jboss.org/browse/JBJCA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefano Maestri resolved JBJCA-902.
-----------------------------------

    Resolution: Done

    
> Unwanted config properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBJCA-902
>                 URL: https://issues.jboss.org/browse/JBJCA-902
>             Project: IronJacamar
>          Issue Type: Bug
>          Components: Common
>    Affects Versions: 1.0.12.Final, 1.1.0.Beta2
>            Reporter: Simone Gotti
>            Assignee: Stefano Maestri
>            Priority: Critical
>             Fix For: 1.0.13.Final, 1.1.0.Beta3
>
>
> With the effects of issue AS7-5644 I noticed that the connection definition with missing system properties, instead of failing, was using properties from another connection definition (with a lot of consequent problems)
> After a lot of analysis the problem is that the org.jboss.jca.common.api.metadata.ra.Connector's system properties are polluted with the merged values of the user specified connectiondefinitions/adminobjects and these system properties's defaults are inserted in the user defined connectiondefinition/adminobject that don't define them.
> I think that the wrong operation is in the start method of org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.java:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(raxml, cmd);
> I think that merging should be between IronJacamar -> Connector and not raxml -> Connector:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(ijmd, cmd);
> After this change I see that the Connector is clean and no unwanted default are added inside my connectiondefinitions/adminobjects
> I'll attach the possible pull request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira