[jboss-jira] [JBoss JIRA] (JGRP-1523) FD_ALL does not unsuspect on heartbeat

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725907#comment-12725907 ] 

Bela Ban commented on JGRP-1523:
--------------------------------

Can you elaborate a bit more ? The suspected_mbrs field is updated also when there is a view change, as all non-members are removed.

Other members need to keep suspected members in their suspected_mbrs list, as they may become coordinator themselves.

The 'wasteful' doesn't really bother me, as there won't be many suspected members in a list at any given time, and they're cleared after the new view excluding them is installed. I do care about the 'wrong' part of your statement. Can you elaborate ?
                
> FD_ALL does not unsuspect on heartbeat
> --------------------------------------
>
>                 Key: JGRP-1523
>                 URL: https://issues.jboss.org/browse/JGRP-1523
>             Project: JGroups
>          Issue Type: Quality Risk
>    Affects Versions: 3.0.14
>            Reporter: Jan Boehm
>            Assignee: Bela Ban
>             Fix For: 3.0.15, 3.2
>
>
> FD_ALL stores suspected nodes in "suspected_mbrs" when it receives no heartbeats. If it does not predict the local node as new coordinator it does not pass this suspicion upwards. Since UNSUSPECT from upwards is the only event that removes a node from suspected_mbrs the set retains all nodes except the nodes that where newly suspected when local became the potential new coordinator.
> This seems wasteful and wrong (it leads to wrong results if there are "stale" suspects that would be preferred as new coordinators). The timestamps for nodes in suspected_mbrs should be rechecked in FD_ALL.suspect before adding the new nodes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira