[jboss-jira] [JBoss JIRA] (AS7-5530) Singletons don't respect @TransactionAttribute/deployment descriptor in @PostConstruct.

[John Mazzitelli (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719283#comment-12719283 ] 

John Mazzitelli commented on AS7-5530:
--------------------------------------

OK, I think I have a workaround. I'll leave it up to the AS guys to determine if this should remain at Major priority level or not. Here's the workaround (it requires a code change):

1) Your original Singleton EJB should no longer have a @PostConstruct annotating your post-construct method. If you used this in conjunction with @Startup, you should no longer have @Startup annotating your class either. Keep your method though - but don't have it annotated with @PostConstruct, and keep the @TransactionAttribute so it is still annotated with NOT_SUPPORTED.

2) Create a new, separate @Singleton EJB bean (call it something like "WorkaroundAS7_5330" or something :-)), this one annotated with @Startup if that's how you had your original singleton EJB. This new class should have your original singleton EJB injected into it (e.g. "@EJB private YourOriginalSingletonClass singleton;"). In your new singleton EJB, create a post construct method, annotate it with @PostConstruct and the body of the method is simply a call to your original EJB's postconstruct method (e.g. this.singleton.yourOriginalPostConstructMethod()). Because your original method is still annotated with NOT_SUPPORTED, the bogus tx that the AS container is giving you will be suspended. When your original post construct method is therefore called, it will not have a tx associated with it.

Hopefully that made sense. Here's an example of that second EJB class:

@Singleton
@Startup
public class WorkaroundAS7_5530 {
    @EJB
    private StartupBean startupBean;

    @PostConstruct
    @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED) // this is ignored because of bug AS7-5530

    public void initWithTransactionBecauseAS75530() throws RuntimeException {
        this.startupBean.init(); // call init() which is NOT_SUPPORTED so it suspends the tx bug AS7-5530 gives us erroneously
    }
}

                
> Singletons don't respect @TransactionAttribute/deployment descriptor in @PostConstruct.
> ---------------------------------------------------------------------------------------
>
>                 Key: AS7-5530
>                 URL: https://issues.jboss.org/browse/AS7-5530
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: EJB
>    Affects Versions: 7.1.1.Final
>         Environment: JBoss 7.1.1
>            Reporter: Sławomir Wojtasiak
>            Assignee: jaikiran pai
>              Labels: rhq
>         Attachments: jboss-as-helloworld-singleton.war
>
>
> Singletons don't respect any transaction attributes for their @PostConstruct methods and invokes them always with REQUIRED_NEW semantics. Following part of code is responsible for hardcoding these values for registered _SingletonLifecycleCMTTxInterceptor_ factories:
> {code:title=org.jboss.as.ejb3.component.singleton.SingletonComponentDescription.java|borderStyle=solid}
>  @Override
>                 public void configure(final DeploymentPhaseContext context, final ComponentDescription description, final ComponentConfiguration configuration) throws DeploymentUnitProcessingException {
>                     configuration.addPostConstructInterceptor(new SingletonLifecycleCMTTxInterceptor.Factory(TransactionAttributeType.REQUIRES_NEW), InterceptorOrder.ComponentPostConstruct.TRANSACTION_INTERCEPTOR);
>                     configuration.addPreDestroyInterceptor(new SingletonLifecycleCMTTxInterceptor.Factory(TransactionAttributeType.REQUIRES_NEW), InterceptorOrder.ComponentPreDestroy.TRANSACTION_INTERCEPTOR);
>                     if(description.isPassivationApplicable()) {
>                         configuration.addPrePassivateInterceptor(new SingletonLifecycleCMTTxInterceptor.Factory(TransactionAttributeType.REQUIRES_NEW), InterceptorOrder.ComponentPassivation.TRANSACTION_INTERCEPTOR);
>                         configuration.addPostActivateInterceptor(new SingletonLifecycleCMTTxInterceptor.Factory(TransactionAttributeType.REQUIRES_NEW), InterceptorOrder.ComponentPassivation.TRANSACTION_INTERCEPTOR);
>                     }
>                     configuration.addTimeoutViewInterceptor(TimerCMTTxInterceptor.FACTORY, InterceptorOrder.View.CMT_TRANSACTION_INTERCEPTOR);
>                 }
> {code}
> EJB 3.1 specification says, REQUIRED, REQUIRED_NEW and NOT_SUPPORTED attributes should be supported, where in case of REQUIRED a semantic of REQUIRED_NEW trancation attribute should be used:
> {panel:title=4.8.3 Transaction Semantics of Initialization and Destruction| borderStyle=dashed| borderColor=#ccc| titleBGColor=#F7D6C1| bgColor=#FFFFCE} 
> PostConstruct and PreDestroy methods of Singletons with container-managed transactions are transactional. From the bean developer’s view there is no client of a PostConstruct or PreDestroy method.
> A PostConstruct or PreDestroy method of a Singleton with container-managed transactions has transaction attribute REQUIRED, REQUIRES_NEW, or NOT_SUPPORTED (Required , RequiresNew, or NotSupported if the deployment descriptor is used to specify the transaction attribute).
> _Note that the container must start a new transaction if the REQUIRED (Required) transaction attribute is used. This guarantees, for example, that the transactional behavior of the PostConstruct method is the same regardless of whether it is initialized eagerly at container startup time or as a side effect of a first client invocation on the Singleton. The REQUIRED transaction attribute value is allowed so that specification of a transaction attribute for the Singleton PostConstruct/PreDestroy methods can be defaulted._
> {panel} 
> So there is not a problem with REQUIRED and REQUIRED_NEW transaction attributes, but NOT_SUPPORTED attribute is just not supported :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira