[jboss-jira] [JBoss JIRA] (AS7-5588) LdapExtLoginModule fails to load roles when a Custom Principal is specified

[Jess Sightler (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720450#comment-12720450 ] 

Jess Sightler commented on AS7-5588:
------------------------------------

Also, on a semi-related note, LdapExtLoginModule.addRoles has this line:
Principal p = super.createIdentity(roleName);

Is it necessary to explicitly call super? This seems to break the ability to override that method in LdapExtLoginModule subclasses.
                
> LdapExtLoginModule fails to load roles when a Custom Principal is specified
> ---------------------------------------------------------------------------
>
>                 Key: AS7-5588
>                 URL: https://issues.jboss.org/browse/AS7-5588
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Security
>    Affects Versions: 7.1.2.Final (EAP)
>            Reporter: Jess Sightler
>            Assignee: Anil Saldhana
>
> LdapExtLoginModule.addRole(String) calls:
> super.createIdentity(roleName);
> This attempts to get the current context classloader for the current thread. Unfortunately, this fails as the context classloader is null.
> The callchain is:
> createLdapInitContext->rolesSearch->addRole
> Lines 432 and 433 of LdapExtLoginModule are:
> if (currentTCCL != null)
>             SecurityActions.setContextClassLoader(null);
> This clears the classloader, so the principal class cannot be loaded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira