[jboss-jira] [JBoss JIRA] (AS7-5648) Unwanted system properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter

[Stefano Maestri (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722300#comment-12722300 ] 

Stefano Maestri commented on AS7-5648:
--------------------------------------

That merge is correct because it's merging raxml metadatas (aka those got from standalone.xml) and not ijmd (metadasta got from ironjacamar.xml).
they could have defaults, even if not specified by user, according to resource description in DMR. What you can do is to check if these values are only ones for which a default is defined. To get them just execute in CLI

/subsystem=resource-adapters/resource-adapter=*:read-resource-description(recursive=true)

and have a look to attributes w/ default defined. For example in connection-definition use-java-context has default = true

"use-java-context" => {
                                "type" => BOOLEAN,
                                "description" => "Setting this to false will bind the object into global JNDI",
                                "expressions-allowed" => true,
                                "nillable" => true,
                                "default" => true,
                                "access-type" => "read-write",
                                "storage" => "configuration",
                                "restart-required" => "no-services"
                            },

                
> Unwanted system properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5648
>                 URL: https://issues.jboss.org/browse/AS7-5648
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JCA
>    Affects Versions: 7.1.3.Final (EAP), 7.2.0.Alpha1
>            Reporter: Simone Gotti
>            Assignee: Stefano Maestri
>
> With the effects of issue AS7-5644 I noticed that the connection definition with missing system properties, instead of failing, was using properties from another connection definition (with a lot of consequent problems)
> After a lot of analysis the problem is that the org.jboss.jca.common.api.metadata.ra.Connector's system properties are polluted with the merged values of the user specified connectiondefinitions/adminobjects and these system properties's defaults are inserted in the user defined connectiondefinition/adminobject that don't define them.
> I think that the wrong operation is in the start method of org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.java:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(raxml, cmd);
> I think that merging should be between IronJacamar -> Connector and not raxml -> Connector:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(ijmd, cmd);
> After this change I see that the Connector is clean and no unwanted default are added inside my connectiondefinitions/adminobjects
> I'll attach the possible pull request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira