[jboss-jira] [JBoss JIRA] (AS7-5648) Unwanted system properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter

[Simone Gotti (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722345#comment-12722345 ] 

Simone Gotti edited comment on AS7-5648 at 9/27/12 11:30 AM:
-------------------------------------------------------------

Hi Stefano,

from what I understand, that instruction is doing the inverse, it's merging the raxml (standalone.xml/domain.xml) inside cmd which is META-INF/ra.xml of the resource adapter.

Isn't the operation of merging the defaults inside the raxml done inside the initAndInject method called by createObjectsAndInjectValue of org.jboss.jca.deployers.common.AbstractResourceAdapterDeployer.java (Object om = initAndInject(mcfClz, cdMeta.getConfigProperties(), cl); at line 1676) ?

In fact, during my analysis when initAndInject is called the values of the cdMeta.getConfigProperties() are polluted withns all the bad default took from the raxml.

Thanks!
Bye!



                
      was (Author: simone.gotti):
    Hi Stefano,

from what I understand, that instruction is doing the inverse, it's merging the raxml (standalone.xml/domain.xml) inside cmd which is META-INF/ra.xml of the resource adapter.

The instruction of merging the defaults inside the raxml isn't done inside the initAndInject method called by createObjectsAndInjectValue of org.jboss.jca.deployers.common.AbstractResourceAdapterDeployer.java (Object om = initAndInject(mcfClz, cdMeta.getConfigProperties(), cl); at line 1676) ?

In fact, during my analysis when initAndInject is called the values of the cdMeta.getConfigProperties() are polluted withns all the bad default took from the raxml.

Thanks!
Bye!



                  
> Unwanted system properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5648
>                 URL: https://issues.jboss.org/browse/AS7-5648
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JCA
>    Affects Versions: 7.1.3.Final (EAP), 7.2.0.Alpha1
>            Reporter: Simone Gotti
>            Assignee: Stefano Maestri
>
> With the effects of issue AS7-5644 I noticed that the connection definition with missing system properties, instead of failing, was using properties from another connection definition (with a lot of consequent problems)
> After a lot of analysis the problem is that the org.jboss.jca.common.api.metadata.ra.Connector's system properties are polluted with the merged values of the user specified connectiondefinitions/adminobjects and these system properties's defaults are inserted in the user defined connectiondefinition/adminobject that don't define them.
> I think that the wrong operation is in the start method of org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.java:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(raxml, cmd);
> I think that merging should be between IronJacamar -> Connector and not raxml -> Connector:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(ijmd, cmd);
> After this change I see that the Connector is clean and no unwanted default are added inside my connectiondefinitions/adminobjects
> I'll attach the possible pull request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira