[jboss-jira] [JBoss JIRA] (AS7-5648) Unwanted system properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter

[Stefano Maestri (JIRA)]

    [ https://issues.jboss.org/browse/AS7-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722411#comment-12722411 ] 

Stefano Maestri commented on AS7-5648:
--------------------------------------

Maybe I'm not understanding...but it's exactly the idea: having metadatas that is results of merging raxml and cmd and use this merged metadatas (w/ all defaults) to create resourceAdapter classes. BTW in this service doesn't make sense to merge ijcmd that should be always empty because this service is triggered only for RA defined in standalone.xml, not having an ironjacamr.xml inside the rar.

But maybe I'm not understanding the problem you are experiencing and I so I can't hint you. You can contact me on IRC (maeste on #jboss-as7 in Freenode), or if it's impossible for you, give me more context here, giving me an example of polluted metadatas and why you consider them wrong.

regards
S. 
                
> Unwanted system properties in a connectiondefinition/adminobject from another connectiondefinition/adminobject in the same resource adapter
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-5648
>                 URL: https://issues.jboss.org/browse/AS7-5648
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JCA
>    Affects Versions: 7.1.3.Final (EAP), 7.2.0.Alpha1
>            Reporter: Simone Gotti
>            Assignee: Stefano Maestri
>
> With the effects of issue AS7-5644 I noticed that the connection definition with missing system properties, instead of failing, was using properties from another connection definition (with a lot of consequent problems)
> After a lot of analysis the problem is that the org.jboss.jca.common.api.metadata.ra.Connector's system properties are polluted with the merged values of the user specified connectiondefinitions/adminobjects and these system properties's defaults are inserted in the user defined connectiondefinition/adminobject that don't define them.
> I think that the wrong operation is in the start method of org.jboss.as.connector.services.resourceadapters.deployment.ResourceAdapterXmlDeploymentService.java:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(raxml, cmd);
> I think that merging should be between IronJacamar -> Connector and not raxml -> Connector:
> cmd = (new Merger()).mergeConnectorWithCommonIronJacamar(ijmd, cmd);
> After this change I see that the Connector is clean and no unwanted default are added inside my connectiondefinitions/adminobjects
> I'll attach the possible pull request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira