[jboss-jira] [JBoss JIRA] (WFLY-89) Spurious server dirs created when directory-grouping="by-type" is set

[James Perkins (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796619#comment-12796619 ] 

James Perkins commented on WFLY-89:
-----------------------------------

After a review of the code and some thought about this I think it might be best to actually create the directories even if they are not used. My reasoning for this is upstream projects or subsystems might expect the {{jboss.server.base.dir}} to return a valid directory. If we do not create these directories then there will not be a valid {{jboss.server.base.dir}} and the responsibility would rely on the consumer of the property to create the directory.

I do however think we should be passing the {{jboss.server.base.dir}} to the servers when creating the launch commands. I think relying on the hard-coded value could be problematic in the future. I'll send a PR with the change soon, but I think this is what we should do; https://github.com/jamezp/wildfly/commit/d8ff4b72d953dcc3dec0e13a4b6043a1f9cf9731. I also think we should just leave the ServerEnvironment in charge of creating the directory if it does not exist.  
                
> Spurious server dirs created when directory-grouping="by-type" is set
> ---------------------------------------------------------------------
>
>                 Key: WFLY-89
>                 URL: https://issues.jboss.org/browse/WFLY-89
>             Project: WildFly
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: James Perkins
>            Priority: Minor
>             Fix For: 8.0.0.Beta1
>
>
> Add directory-grouping="by-type" to the <host><servers> element in the stock host.xml and run domain.sh. The following empty directories are created:
> $JBOSS_HOME/domain/servers/server-one
> $JBOSS_HOME/domain/servers/server-two
> The content that would normally be in those dirs if directory-grouping="by-type" wasn't set appears to all be going where it should (e.g. under domain/data, domain/log etc) so the only issue here is the empty directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira