[jboss-jira] [JBoss JIRA] (WFLY-1933) Disabled data-source without explicit enabled="false" in configuration xml file is re-enabled again after server reload

[Ivo Studensky (JIRA)]

Ivo Studensky created WFLY-1933:
-----------------------------------

             Summary: Disabled data-source without explicit enabled="false" in configuration xml file is re-enabled again after server reload
                 Key: WFLY-1933
                 URL: https://issues.jboss.org/browse/WFLY-1933
             Project: WildFly
          Issue Type: Bug
          Components: JCA
    Affects Versions: 8.0.0.Alpha4
            Reporter: Ivo Studensky
            Assignee: Ivo Studensky


The server automatically re-enables a data-source which was disabled before and which lost {{enabled="false"}} in the configuration XML file. 

There is a madness between the default value of the {{enabled}} attribute in XSD and the same attribute definition in org.jboss.as.connector.subsystems.datasources.Constants. From my POV any data-source that has been disabled before should stay in that state unless it is explicitly enabled again. See https://bugzilla.redhat.com/show_bug.cgi?id=952277 for a reproducer. 

The culprit seems to be 
{code:java|title=org.jboss.as.connector.subsystems.datasources.DsParser}
...
    private void parseDataSource(final XMLExtendedStreamReader reader, final List<ModelNode> list, final ModelNode parentAddress) throws XMLStreamException, ParserException,
            ValidateException {
...
==>        boolean enabled = Defaults.ENABLED.booleanValue();
...
    private void parseXADataSource(XMLExtendedStreamReader reader, final List<ModelNode> list, final ModelNode parentAddress) throws XMLStreamException, ParserException,
            ValidateException {
...
==>        boolean enabled = Defaults.ENABLED.booleanValue();
...
{noformat}

Though it looks like a bug, I am not sure we can change the default value in XSD for EAP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira