[jboss-jira] [JBoss JIRA] (JBJCA-1127) Contention fix when returning connections

[Jeremy Whiting (JIRA)]

    [ https://issues.jboss.org/browse/JBJCA-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931767#comment-12931767 ] 

Jeremy Whiting commented on JBJCA-1127:
---------------------------------------

 I suspect the pool modification of the permits should be in the synchronized block.

 A couple of additional small changes to John's commit to move code outside the block.
https://github.com/whitingjr/ironjacamar/commit/ecde3e126f4ad28ec848bc21174ef1bcfb096487

                
> Contention fix when returning connections
> -----------------------------------------
>
>                 Key: JBJCA-1127
>                 URL: https://issues.jboss.org/browse/JBJCA-1127
>             Project: IronJacamar
>          Issue Type: Enhancement
>          Components: Performance
>    Affects Versions: 1.0.23.Final, 1.1.2.Final
>            Reporter: Ståle Pedersen
>            Assignee: Jesper Pedersen
>
> During benchmarking we saw a lot of contention when hibernate is returning connections.
> With this fix below the total contention time (aggregated across all threads) over a 5min period in s/state for that lock in SemaphoreArrayListManagedConnectionPool has gone from 39min 55s to 17s.
> https://github.com/johnaoahra80/ironjacamar/commit/f32885818bc0048522a0865dd89e98719853c74f
> We havent seen any errors with this change in the IJ testsuite or in the benchmark we're running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira