[jboss-jira] [JBoss JIRA] (AS7-6532) Enable the reverse controller check for the jacorb subsystem transformer test

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-6532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754580#comment-12754580 ] 

Brian Stansberry commented on AS7-6532:
---------------------------------------

I think there's a problem in the :add handler re: attribute "security". My guess is the transformer is transforming "identity" to "on" but then the add handler is not properly dealing with "on". JacorbReloadRequiredWriteAttributeHandler has logic to convert "on" to "identity", as does the parser, but I don't see that in JacORBSubsystemAdd.

This attribute supports expressions, so doing the translation in Stage.MODEL is insufficient. A check for "on" has to be done in the runtime handling as well.

junit.framework.ComparisonFailure: security/
"identity"
"on"
----- 
Expected :on
Actual   :identity
 <Click to see difference>
	at org.jboss.as.model.test.ModelTestUtils.compare(ModelTestUtils.java:385)
	at org.jboss.as.model.test.ModelTestUtils.compare(ModelTestUtils.java:358)
	at org.jboss.as.model.test.ModelTestUtils.compare(ModelTestUtils.java:211)
	at org.jboss.as.model.test.ModelTestUtils.compare(ModelTestUtils.java:187)
	at org.jboss.as.subsystem.test.SubsystemTestDelegate$LegacyKernelServiceInitializerImpl.bootCurrentVersionWithLegacyBootOperations(SubsystemTestDelegate.java:733)
	at org.jboss.as.subsystem.test.SubsystemTestDelegate$LegacyKernelServiceInitializerImpl.install(SubsystemTestDelegate.java:675)
	at org.jboss.as.subsystem.test.SubsystemTestDelegate$LegacyKernelServiceInitializerImpl.access$700(SubsystemTestDelegate.java:617)
	at org.jboss.as.subsystem.test.SubsystemTestDelegate$KernelServicesBuilderImpl.build(SubsystemTestDelegate.java:589)
	at org.jboss.as.jacorb.JacORBTransformersTestCase.testTransformersSecurityIdentity_1_1_0(JacORBTransformersTestCase.java:149)
	at org.jboss.as.jacorb.JacORBTransformersTestCase.testTransformersSecurityIdentity712(JacORBTransformersTestCase.java:130)
                
> Enable the reverse controller check for the jacorb subsystem transformer test
> -----------------------------------------------------------------------------
>
>                 Key: AS7-6532
>                 URL: https://issues.jboss.org/browse/AS7-6532
>             Project: Application Server 7
>          Issue Type: Sub-task
>          Components: Domain Management
>            Reporter: Kabir Khan
>            Assignee: Brian Stansberry
>             Fix For: 7.3.0.Alpha1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira