[jboss-jira] [JBoss JIRA] (AS7-6261) Deployment fails while previous message implies content was fine

[David Lloyd (JIRA)]

     [ https://issues.jboss.org/browse/AS7-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Lloyd updated AS7-6261:
-----------------------------

    Component/s: EE
                     (was: MSC)


I believe this is a problem in the descriptor parser, which is not adequately validating.
                
> Deployment fails while previous message implies content was fine
> ----------------------------------------------------------------
>
>                 Key: AS7-6261
>                 URL: https://issues.jboss.org/browse/AS7-6261
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: EE
>    Affects Versions: 7.1.1.Final
>         Environment: Ubuntu Linux 12.10, x86_64
>            Reporter: Jari Juslin
>            Assignee: David Lloyd
>
> In jboss-app.xml old style markup like this:
> <module-order>strict</module-order>
> causes the whole deployment roll back. However, the deployer first claims it's OK and then throws undecipherable Exception message adding to the confusion.
> It is OK to refuse to deploy because XML contains invalid element, but _not_ OK to fail to deploy and not tell that element was invalid, but instead suggest the XML was malformed, which it was not.
> Beginning of the jboss-app.xml:
> <?xml version="1.0" encoding="UTF-8"?>
> <jboss-app xmlns="http://www.jboss.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>   version="7.0">
>   <module-order>strict</module-order>
> And the Exception:
> 17:04:32,075 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-5) JBAS015876: Starting deployment of "foo.ear"
> 17:04:32,099 WARN  [org.jboss.metadata.parser.jboss.JBossAppMetaDataParser] (MSC service thread 1-2) module-order element in jboss-app.xml is deprecated and has been ignored
> 17:04:32,103 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC00001: Failed to start service jboss.deployment.unit."foo.ear".STRUCTURE: org.jboss.msc.service.StartException in service jboss.deployment.unit."foo.ear".STRUCTURE: Failed to process phase STRUCTURE of deployment "foo.ear"
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:119) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [rt.jar:1.6.0_33]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [rt.jar:1.6.0_33]
> 	at java.lang.Thread.run(Thread.java:662) [rt.jar:1.6.0_33]
> Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: JBAS011059: Failed to parse "/content/foo.ear/META-INF/jboss-app.xml"
> 	at org.jboss.as.ee.structure.EarMetaDataParsingProcessor.handleJbossMetadata(EarMetaDataParsingProcessor.java:123)
> 	at org.jboss.as.ee.structure.EarMetaDataParsingProcessor.deploy(EarMetaDataParsingProcessor.java:64)
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:113) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
> 	... 5 more
> Caused by: com.ctc.wstx.exc.WstxParsingException: Received non-all-whitespace CHARACTERS or CDATA event in nextTag().
>  at [row,col {unknown-source}]: [4,22]
> 	at com.ctc.wstx.sr.StreamScanner.constructWfcException(StreamScanner.java:606)
> 	at com.ctc.wstx.sr.StreamScanner.throwParseError(StreamScanner.java:479)
> 	at com.ctc.wstx.sr.StreamScanner.throwParseError(StreamScanner.java:464)
> 	at com.ctc.wstx.sr.BasicStreamReader.nextTag(BasicStreamReader.java:1137)
> 	at org.jboss.metadata.parser.jboss.JBossAppMetaDataParser.parse(JBossAppMetaDataParser.java:88)
> 	at org.jboss.as.ee.structure.EarMetaDataParsingProcessor.handleJbossMetadata(EarMetaDataParsingProcessor.java:120)
> 	... 7 more

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira