[jboss-jira] [JBoss JIRA] (AS7-6262) Dynamically added JSF converter ignored in some cases since Mojarra 2.1.16 upgrade

[Marek Schmidt (JIRA)]

    [ https://issues.jboss.org/browse/AS7-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743514#comment-12743514 ] 

Marek Schmidt commented on AS7-6262:
------------------------------------

Well, if in my original code I instead of a converter add an ordinary component, e.g.:

{code}
private void addSelectionConverter() {
      UIComponent parentComponent = getParent();
      
      System.out.println("Adding a XXX component");
      UIOutput output = new UIOutput();
      output.setValue("XXX");
      parentComponent.getParent().getChildren().add(output);
   }
{code}

click add it renders XXX per every Item and the "Adding a XXX component" is printed only once during the initial rendering, which is as it should IMHO (the component gets added to the tree during the first render and then stays there, as the tree is preserved during the view lifecycle across multiple requests)

The fact that the component/converter is inside a ui:repeat should not really matter, as ui:repeat does not create new component instances in the tree, it just renders the component multiple times. So adding a converter before the first render should be mostly equivalent of having the converter there from the beginning in the .xhtml page (which works). So anyway, that is my theory why the original code should work. I'd love to know which of my assumptions are wrong...
                
> Dynamically added JSF converter ignored in some cases since Mojarra 2.1.16 upgrade
> ----------------------------------------------------------------------------------
>
>                 Key: AS7-6262
>                 URL: https://issues.jboss.org/browse/AS7-6262
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JSF
>    Affects Versions: 7.1.4.Final (EAP)
>         Environment: Current 7.1.4.Final-SNAPSHOT (2013-01-02 be583f5)
>            Reporter: Marek Schmidt
>            Assignee: Stan Silvert
>             Fix For: 7.1.4.Final (EAP)
>
>         Attachments: AS7-6262.tar.gz, AS7-6262.war
>
>
> Dynamically created converters seems to be ignored in some special cases, like the following.
> Having a form like this:
> {code}
>     <h:form>
>         <ul>
>             <ui:repeat value="#{basket.items}" var="i">
>                 <li>Item #{i.number}
>                     <h:selectOneMenu value="#{i.color}">
>                         <test:selectColors />
>                     </h:selectOneMenu>
>                 </li>
>             </ui:repeat>
>         </ul>
>         <div>
>             <h:commandButton value="Add" action="#{basket.add}" />
>         </div>
>         <h:outputText value="#{basket.string}" />
>         </h:form>
> {code}
> Where SelectColors is
> {code}
> @JsfComponent(description=@Description(displayName="org.jboss.seam.test.SelectColors",value="Creates a List<SelectItem> of colors."),
> family="javax.faces.SelectItems", type="org.jboss.seam.test.SelectColors",generate="org.jboss.seam.test.html.HtmlSelectColors", 
> tag = @Tag(baseClass="javax.faces.webapp.UIComponentTagBase", name="selectColors"))
> public class SelectColors extends javax.faces.component.UISelectItems implements SystemEventListener {
>    public SelectColors() {
>       FacesContext context = FacesContext.getCurrentInstance();
>       UIViewRoot root = context.getViewRoot();
>       root.subscribeToViewEvent( PreRenderViewEvent.class, this );
>    }
>    @Override
>    public Object getValue() {
>       List<SelectItem> ret = new LinkedList<SelectItem> ();
>       ret.add(new SelectItem("default", "Select color... (black by default)"));
>       ret.add(new SelectItem("red", "Red"));
>       ret.add(new SelectItem("white", "White"));
>       ret.add(new SelectItem("blue", "Blue"));
>       ret.add(new SelectItem("black", "Black"));
>       return ret;
>    }
>    private void addSelectionConverter() {
>       UIComponent parentComponent = getParent();
>       if (parentComponent instanceof ValueHolder) {
>          ValueHolder parentValueHolder = (ValueHolder) parentComponent;
>          Converter parentConverter = parentValueHolder.getConverter();
>          if (parentConverter == null) {
>             parentValueHolder.setConverter(new DefaultColorConverter());
>          }
>       }
>    }
>    @Override
>    public void processEvent(SystemEvent event) throws AbortProcessingException
>    {
>       if ( !FacesContext.getCurrentInstance().isPostback() ) {
>          addSelectionConverter();
>       }
>    }
>    @Override
>    public boolean isListenerForSource(Object source)
>    {
>       return ( source instanceof UIViewRoot );
>    }
> }
> {code}
> and the DefaultColorConverter being:
> {code}
> @FacesConverter(value="org.jboss.seam.test.DefaultColorConverter")
> public class DefaultColorConverter implements Converter
> {
>    public static final String DEFAULT_COLOR = "black";
>    public Object getAsObject(FacesContext context, UIComponent component, String value) throws ConverterException
>    {
>       if ("default".equals(value)) {
>     	  return DEFAULT_COLOR;
>       }
>       
>       return value;
>    }
>    public String getAsString(FacesContext context, UIComponent component, Object value) throws ConverterException
>    {
>       return value.toString();
>    }
> }
> {code}
> In the pre-Mojarra 2.1.16 upgrade, clicking on the add button repeatedly creates "black" items. Post mojarra 2.1.16, it sets the color to "default", which should never happen, as the converter should convert the "default" value into "black".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira