[jboss-jira] [JBoss JIRA] (AS7-1833) CLI usability: operations that shutdown the server-side management interface result in "Communication error"

[Alexey Loubyansky (JIRA)]

    [ https://issues.jboss.org/browse/AS7-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743806#comment-12743806 ] 

Alexey Loubyansky commented on AS7-1833:
----------------------------------------

Here is the pull request https://github.com/jbossas/jboss-as/pull/3808

The cli is now notified when the connection is closed. But this happens asynchronously. I.e. normally the CLI is in the waiting for the user input state and when the notification is received, it can internally switch to the disconnected state but it can't change the prompt to indicate that until the user enters the next line (i.e. it will remain indicating standalone or domain mode). Perhaps, Stale will add some trick to aesh to fix this issue later.

The above is mostly for the operations. The commit also adds higher level commands: shutdown and reload. They reflect the operations. The only difference is that they wait/block until the connection has been closed and then return the control to the client. This fixes the prompt issue above (i.e. it's correctly updated during the command execution) but there could still be race conditions.

Commands following immediately after reload or 'shutdown --restart=true' might be executed by the CLI before the target has finished the reload/restart since there is no notification of the server/controller being up again.
                
> CLI usability: operations that shutdown the server-side management interface result in "Communication error"
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-1833
>                 URL: https://issues.jboss.org/browse/AS7-1833
>             Project: Application Server 7
>          Issue Type: Enhancement
>          Components: CLI
>    Affects Versions: 7.0.0.Final, 7.0.1.Final
>            Reporter: Radoslav Husar
>            Assignee: Alexey Loubyansky
>            Priority: Critical
>              Labels: eap6-ux
>             Fix For: 7.2.0.CR1
>
>
> If you shutdown the server, you get an error:
> {code}
> [standalone at localhost:9999 /] :shutdown
> Communication error: Channel closed
> Closed connection to localhost:9999
> {code}
> Even though its considered by this comment clean - https://issues.jboss.org/browse/AS7-689?focusedCommentId=12614756&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12614756 - I is not really clean as you get an error but termination of the channel can be anticipated. Users might be confused now knowing if its an actual error or not. For example take a look at SSH.
> The same basic issue exists for the :reload operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira