[jboss-jira] [JBoss JIRA] (AS7-6334) Ensure there is expression testing, basic transformation testing and reject-expression transformation testing for all subsystems

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/AS7-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749561#comment-12749561 ] 

Brian Stansberry commented on AS7-6334:
---------------------------------------

Kabir, good idea -- it would be wise to test that JSF works on a legacy slave when the profile has a simple empty jsf subsystem.

Also, from an earlier IRC discussion:

bstansberry: jmesnil: JSF was broken out from web
[12:22pm] bstansberry: jmesnil: it has one attribute, to declare the default module slot for loading some JSF-modules
[12:23pm] bstansberry: if that is undefined or has a value of "main" then the entire subsystem can be discarded
[12:24pm] bstansberry: but if it has some other value, some sort of failure needs to happen if the extension and subsystem are not ignored
[12:24pm] bstansberry: what DomainTransformers has now AFAICT *always* discards the subsystem, which is wrong
[12:25pm] jmesnil: bstansberry: ok, I see
[12:25pm] jmesnil: bstansberry: I'll fix it. I'll remove the code from the domain transformers and a a resource transformer with the correct login in the subsystem
[12:25pm] bstansberry: jmesnil: I doubt it can be done in the subsystem, although I could be wrong
[12:26pm] bstansberry: jmesnil: I don't think the API supports "transform to subsystem version null" which is what would be required
[12:27pm] bstansberry: null because the version doesn't exist
[12:27pm] jmesnil: bstansberry: ah, that's why it's done at the upper level
[12:27pm] bstansberry: right
[12:27pm] bstansberry: / Discard all operations to the newly introduced jsf extension
[12:27pm] bstansberry:             domain.registerSubResource(JSF_EXTENSION, IGNORED_EXTENSIONS);
[12:27pm] bstansberry:             // Ignore the jsf subsystem as well
[12:27pm] bstansberry:             registry.registerSubsystemTransformers(JSF_SUBSYSTEM, IGNORED_SUBSYSTEMS, ResourceTransformer.DISCARD);
[12:27pm] bstansberry: I think the 1st part is ok
[12:27pm] jmesnil: bstansberry: ok, so the code stays in domain transformers but it need a more specific resource transformer than DISCARD
[12:28pm] bstansberry: but yeah the 2nd needs something more
[12:28pm] jmesnil: bstansberry: I'll work on it
[12:28pm] bstansberry: to be future proof, I think the rules are
[12:29pm] bstansberry: 1) If the resource has any defined attributes other than the 1 that's there now, that's a problem
[12:29pm] bstansberry: 2) if that 1 attribute is there and isn't "main" that's a problem
[12:29pm] bstansberry: if there is no problem, then discard

It would be nice if that could be tested in ProfileTransformersTestCase or something similar. Might not work though since its a subsystem. The test fixture might not need to use an actual JSF subsystem though; just a mock that looks like JSF would do. A manual test is fine for now too.
                
> Ensure there is expression testing, basic transformation testing and reject-expression transformation testing for all subsystems
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-6334
>                 URL: https://issues.jboss.org/browse/AS7-6334
>             Project: Application Server 7
>          Issue Type: Task
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 7.2.0.Alpha1
>
>
> Task to track the work we've all been doing on expressions/transformers.
> See JaxrSubsystemTestCase for an example of what I'd like to see for each subsystem:
> 1) The standard subsystem test applied to a config that covers the full xsd with expressions added to each relevant attribute.
> 2) Basic transformation testing against 7.1.2 and 7.1.3
> 3) Reject-expression testing against 7.1.2 and 7.1.3
> Assigned to me but this is really a team effort, with a big chunk already done. Please use comments on this JIRA to indicate if you're looking at something.
> Please edit this description and put an OK after the subsystem name to indicate it's good to go.
> clustering/jgroups (OK)
> clustering/infinispan
> cmp
> configadmin [OK]
> connector/datasource
> connector/jca [OK]
> connector/resource-adapter
> deployment-scanner
> ee
> ejb3 [OK]
> jacorb
> jaxr OK
> jaxrs - nothing to do, empty subsystem
> jdr - nothing to do, empty subsystem
> jmx (OK)
> jpa (OK)
> jsf [WIP JFM]
> jsr77 - nothing to do, empty subsystem
> logging
> mail
> messaging [OK]
> modcluster
> naming [PR https://github.com/jbossas/jboss-as/pull/3910]
> osgi (OK)
> pojo - nothing to do, empty subsystem
> remoting - [OK]
> sar - nothing to do, empty subsystem
> security
> threads
> transactions (just needs AS7-6336)
> web
> webservices
> weld - nothing to do, empty subsystem
> xts - nothing to do, susbystem model has not changed since 7.1.2 & 7.1.3

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira