[jboss-jira] [JBoss JIRA] (AS7-6387) Improper error handling when attempting to remove a server-config with a running server

[Brian Stansberry (JIRA)]

     [ https://issues.jboss.org/browse/AS7-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry reassigned AS7-6387:
-------------------------------------

    Assignee: Emanuel Muckenhuber  (was: Brian Stansberry)


Emanuel, assigning to you to get your comment on why the code that causes the failure Osamu Nagano reports is there:

ServerRemoveHandler, L69-71

{code}
if(! context.getResourceRegistration().getChildNames(PathAddress.EMPTY_ADDRESS).contains(SERVER)) {
                    throw new OperationFailedException(new ModelNode().set(context.getResourceRegistration().getChildNames(PathAddress.EMPTY_ADDRESS).toString()));
                }
{code}

This will fail with a not very useful error message if no servers are started. I don't see why the presence of child type 'server' is required.

Solving that bit isn't the entire fix though. My original problem description is a different case, where the server is still running and thus the op *should* fail but the error message isn't reported correctly.
                
> Improper error handling when attempting to remove a server-config with a running server
> ---------------------------------------------------------------------------------------
>
>                 Key: AS7-6387
>                 URL: https://issues.jboss.org/browse/AS7-6387
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 7.1.2.Final (EAP), 7.1.3.Final (EAP)
>            Reporter: Brian Stansberry
>            Assignee: Emanuel Muckenhuber
>             Fix For: 7.2.0.Alpha1
>
>
> Trying to remove the config for server-one while it's still running produces an uninformative failure:
> [domain at localhost:9999 /] /host=master/server-config=server-one:remove
> {
>     "outcome" => "failed",
>     "result" => undefined,
>     "rolled-back" => true,
>     "server-groups" => undefined
> }
> An EAP 6 user reported a similar problem but with a different response:
> [domain at localhost:9999 /] /host=xyz/server-config=as1:remove
> {
>     "outcome" => "success",
>     "result" => {
>         "outcome" => "failed",
>         "failure-description" => "[core-service, path, server-config, system-property, jvm, interface]",
>         "rolled-back" => true
>     },
>     "failure-description" => undefined
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira