[jboss-jira] [JBoss JIRA] (JGRP-1575) View members should be always unmodifiable
Gray Watson (JIRA)
jira-events at lists.jboss.org
Tue Jan 29 17:02:47 EST 2013
[ https://issues.jboss.org/browse/JGRP-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gray Watson updated JGRP-1575:
------------------------------
Description:
Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList.
In my opinion, in the View constructor, members should be a final Collections.unmodifiableList from the start. This would save GC throughput on all of the wrapper objects.
was:Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList. In my view in the constructor members should be a final Collections.unmodifiableList. This would save GC throughput on all of the wrapper objects.
> View members should be always unmodifiable
> ------------------------------------------
>
> Key: JGRP-1575
> URL: https://issues.jboss.org/browse/JGRP-1575
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 3.1, 3.2
> Reporter: Gray Watson
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.3
>
>
> Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList.
> In my opinion, in the View constructor, members should be a final Collections.unmodifiableList from the start. This would save GC throughput on all of the wrapper objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list