[jboss-jira] [JBoss JIRA] (LOGMGR-68) periodic-rotating-file-handler not rotating

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/LOGMGR-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787951#comment-12787951 ] 

RH Bugzilla Integration commented on LOGMGR-68:
-----------------------------------------------

Kyle Lape <klape at redhat.com> made a comment on [bug 981544|https://bugzilla.redhat.com/show_bug.cgi?id=981544]

I actually asked James about this issue a couple of days ago.  I developed a patch similar to Takayoshi's:

index 406ff7d..28deb97 100644
--- a/src/main/java/org/jboss/logmanager/handlers/PeriodicRotatingFileHandler.java
+++ b/src/main/java/org/jboss/logmanager/handlers/PeriodicRotatingFileHandler.java
@@ -214,6 +214,7 @@ public class PeriodicRotatingFileHandler extends FileHandler {
                 calendar.clear(Calendar.DAY_OF_WEEK_IN_MONTH);
             case DAY:
                 calendar.set(Calendar.HOUR_OF_DAY, 0);
+                calendar.set(Calendar.AM_PM, 0);
             case HALF_DAY:
                 calendar.set(Calendar.HOUR, 0);
             case HOUR:

And James's response:

I started looking at this briefly, but didn't dig into it yet. I was trying to get a test case to break it, but I haven't yet. I'll have a look soon at that though. It could be as simple as that for sure. In fact, my gut is telling me that's exactly what it is.
                
> periodic-rotating-file-handler not rotating
> -------------------------------------------
>
>                 Key: LOGMGR-68
>                 URL: https://issues.jboss.org/browse/LOGMGR-68
>             Project: JBoss Log Manager
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 1.4.0.Final
>         Environment: FreeBSD hostname 10.0-CURRENT FreeBSD 10.0-CURRENT #3 r242434M
>            Reporter: Alexander Yerenkow
>            Assignee: Takayoshi Kimura
>
> During day there could be few restarts of JBoss 7.2.0
> If there was one, next day logs aren't rotated.
> edb.log (contains record from 22 apr till now)
> edb.log.2013-04-12 (contains record from 06 apr till 12)
> edb.log.2013-04-17 (contains record from 13 apr till 17)
> edb.log.2013-04-19 (contains record from 18 apr till 19)
> Can't see clear system;
> Here's my config:
>             <periodic-rotating-file-handler name="EDB" autoflush="true">
>                 <formatter>
>                     <pattern-formatter pattern="%d %-5p [%c] (%t:%x) %s%E%n"/>
>                 </formatter>
>                 <file relative-to="jboss.server.log.dir" path="edb.log"/>
>                 <suffix value=".yyyy-MM-dd"/>
>                 <append value="true"/>
>             </periodic-rotating-file-handler>
> This all worked as charm in 7.1.1 / 7.1.3.
> Should I run some tests/ gather some info to fix this?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira