[jboss-jira] [JBoss JIRA] (WFLY-1736) CommandLineArgumentUsage class substring value discarded

[Cheng Fang (JIRA)]

Cheng Fang created WFLY-1736:
--------------------------------

             Summary: CommandLineArgumentUsage class substring value discarded
                 Key: WFLY-1736
                 URL: https://issues.jboss.org/browse/WFLY-1736
             Project: WildFly
          Issue Type: Bug
          Components: CLI
    Affects Versions: 8.0.0.Beta1
            Reporter: Cheng Fang
            Assignee: Alexey Loubyansky


CommandLineArgumentUsage class has a substring call but return value discarded:
{code}
if( input.get(0).length() > width ){
                    String tooLong = input.remove(0);
                    tooLong.substring(0, width-5);
                    input.add("Command removed. Too long.");
                }
{code}

FindBugs also finds a static field should be final:
{code}
protected static List<String> instructions = new ArrayList<String>();
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira