[jboss-jira] [JBoss JIRA] (WFLY-1792) build.sh fails with coomand line arguments with spaces

Aleksandar Kostadinov (JIRA) jira-events at lists.jboss.org
Wed Jul 31 16:15:27 EDT 2013


     [ https://issues.jboss.org/browse/WFLY-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksandar Kostadinov updated WFLY-1792:
----------------------------------------

    Git Pull Request: https://github.com/wildfly/wildfly/pull/4863


here it is: https://github.com/wildfly/wildfly/pull/4863
                
> build.sh fails with coomand line arguments with spaces
> ------------------------------------------------------
>
>                 Key: WFLY-1792
>                 URL: https://issues.jboss.org/browse/WFLY-1792
>             Project: WildFly
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: No Release
>            Reporter: Aleksandar Kostadinov
>            Assignee: Paul Gier
>
> An execution like:
> {code}./build.sh validate -Dmaven.local.repo="asd dsa"{code}
> Fails because handling of command line arguments of build.sh is broken.
> btw I can't understand why there should be this block of code:
> {code}    for param in $@ ; do
>         case $param in
>             ## -s .../settings.xml - don't use our own.
>             -s)      MVN_SETTINGS_XML_ARGS="";   ADDIT_PARAMS="$ADDIT_PARAMS $param";;
>             -*)      ADDIT_PARAMS="$ADDIT_PARAMS $param";;
>             clean)   MVN_GOAL="$MVN_GOAL$param ";;
>             test)    MVN_GOAL="$MVN_GOAL$param ";;
>             install) MVN_GOAL="$MVN_GOAL$param ";;
>             deploy)  MVN_GOAL="$MVN_GOAL$param ";;
>             site)    MVN_GOAL="$MVN_GOAL$param ";;
>             *)       ADDIT_PARAMS="$ADDIT_PARAMS $param";;
>         esac
>     done{code}
> I can't spot anything useful it does but anyways, I'll prepare a pull request for fixing it in a minute.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jboss-jira mailing list