[jboss-jira] [JBoss JIRA] (JGRP-1638) Memory leak

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779105#comment-12779105 ] 

Bela Ban commented on JGRP-1638:
--------------------------------

The problem was caused by the STABILITY message being sent unreliably (Message.Flag.NO_RELIABILITY): if this message was not received by the coordinator, it would not clear its 'votes' set and discard all subsequent STABLE messages from all members already in 'votes'. This means that the coordinator would *not* send new STABILITY messages from then on, blocking all progress and increasing memory due to message accumulation in NAKACK2.

The reason this was less likely to happen with send_stable_msgs_to_coord_only=false was that as long as not *every* member drops the STABILITY message, some member will clear 'votes' and will thus send a STABILITY message.

So the design relied on the fact that, while STABLE messages might get dropped, STABILITY messages could never be dropped. Changing this invalidated the design assumption.

SOLUTION: make STABILITY reliable again. This is OK as we're sending many STABLE messages but only relatively few STABILITY messages.
                
> Memory leak
> -----------
>
>                 Key: JGRP-1638
>                 URL: https://issues.jboss.org/browse/JGRP-1638
>             Project: JGroups
>          Issue Type: Task
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>            Priority: Critical
>             Fix For: 3.4
>
>
> Running MPerf with conf/fast-local.xml (2 members on the same host, 20 million messages each) creates a memory leak in 3.4.x.
> This runs perfectly 3.2.8.Final, so it must be something that was introduced in 3.3.x (3.4.x at this time has almost no diffs to 3.3.0.Final).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira