[jboss-jira] [JBoss JIRA] (BPEL-316) jBPM Designer fullscreen always true

[Jurriën Stutterheim (JIRA)]

     [ https://issues.jboss.org/browse/BPEL-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jurriën Stutterheim updated BPEL-316:
-------------------------------------

    Description: 
jBPM Designer contains the following line (114) in its client's main.js:

{code:JavaScript}
this.fullscreen = model.fullscreen || true;
{code}

This causes this.fullscreen to be always true, which is not desirable.
I propose changing it to the following:

{code:JavaScript}
if (model.fullscreen === null) {
  model.fullscreen = true;
}
this.fullscreen = model.fullscreen;
{code}

  was:
jBPM Designer contains the following line (114) in its client's main.js:

{code:JavaScript}
this.fullscreen = model.fullscreen || true;
{code}

This causes this.fullscreen to be always true, which is not desirable.
I propose changing it to the following:

{code:JavaScript}
if (!model.fullscreen) {
  model.fullscreen = true;
}
this.fullscreen = model.fullscreen;
{code}


    
> jBPM Designer fullscreen always true
> ------------------------------------
>
>                 Key: BPEL-316
>                 URL: https://issues.jboss.org/browse/BPEL-316
>             Project: jBPM BPEL
>          Issue Type: Patch
>      Security Level: Public(Everyone can see) 
>            Reporter: Jurriën Stutterheim
>            Assignee: Alejandro Guizar
>            Priority: Minor
>
> jBPM Designer contains the following line (114) in its client's main.js:
> {code:JavaScript}
> this.fullscreen = model.fullscreen || true;
> {code}
> This causes this.fullscreen to be always true, which is not desirable.
> I propose changing it to the following:
> {code:JavaScript}
> if (model.fullscreen === null) {
>   model.fullscreen = true;
> }
> this.fullscreen = model.fullscreen;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira