[jboss-jira] [JBoss JIRA] (WFLY-1554) Service changes due to rollback should be completed before operation completes

Fri Jun 21 13:22:20 EDT 2013

    [ https://issues.jboss.org/browse/WFLY-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783702#comment-12783702 ] 

Brian Stansberry commented on WFLY-1554:
----------------------------------------

A comment re: https://github.com/wildfly/wildfly/pull/4682

A concern I have with this change is (I think) coverage of the fact that adding a scanner results in a scan run has been dropped. Since that scan will happen async, some sort of check with a timeout is needed. Polling with a long timeout is better than the previous simple "sleep and check once" approach though.

Despite the above I'm fine with merging this; the test needs to be stable. Please leave the JIRA open though.

Testing that adding the scanner results in a scan can likely be done in the deployment-scanner subsystem testsuite, in which case having it duplicated here is unnecessary.

> Service changes due to rollback should be completed before operation completes
> ------------------------------------------------------------------------------
>
>                 Key: WFLY-1554
>                 URL: https://issues.jboss.org/browse/WFLY-1554
>             Project: WildFly
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 8.0.0.Alpha1
>            Reporter: Tomaz Cerar
>            Assignee: jaikiran pai
>
> "As executeAndRollbackOperation() result is retrieved but actual rollback of deployment is is not complete."
> That's a bug then. Service changes due to rollback should be completed before the operation returns. 
> for more details see https://github.com/wildfly/wildfly/pull/4664
> and DeploymentScannerTestCase

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira