[jboss-jira] [JBoss JIRA] (SECURITY-742) JBossPDP.evaluate() lock should be flexible

Wed Jun 26 07:09:22 EDT 2013

    [ https://issues.jboss.org/browse/SECURITY-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784695#comment-12784695 ] 

Siamak Sadeghianfar commented on SECURITY-742:
----------------------------------------------

The readwrite lock doesn't affect the performance here since the write lock is held for the entire evaludate() method. It acts a mutual exclusion lock. The write lock should be held right when we want to update the decision caches:
https://github.com/siamaksade/security-xacml/commit/64c7701a5b37e849576a36d2e64aaaae9210e20a

> JBossPDP.evaluate() lock should be flexible
> -------------------------------------------
>
>                 Key: SECURITY-742
>                 URL: https://issues.jboss.org/browse/SECURITY-742
>             Project: PicketBox 
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JBossXACML
>            Reporter: Anil Saldhana
>            Assignee: Anil Saldhana
>             Fix For: picketbox_xacml_2.0.9.Final
>
>
> SECURITY-418 has comments on how the re-entrant lock is creating performance issues. The evaluate method lock should be configurable - reentrant or rewrite or be lockfree.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira