[jboss-jira] [JBoss JIRA] (DROOLS-62) improve handling of subclasses of Spring transaction manager in SingleSessionCommandService.initTransactionManager(..)

[kgeis (JIRA)]

kgeis created DROOLS-62:
---------------------------

             Summary: improve handling of subclasses of Spring transaction manager in SingleSessionCommandService.initTransactionManager(..)
                 Key: DROOLS-62
                 URL: https://issues.jboss.org/browse/DROOLS-62
             Project: Drools
          Issue Type: Enhancement
      Security Level: Public (Everyone can see)
    Affects Versions: 5.5
            Reporter: kgeis
            Assignee: Mark Proctor


SingleSessionCommandService.initTransactionManager(..) checks the transaction manager that is passed in to see if it is from the Spring Framework:

{code}
if ( tm != null && tm.getClass().getName().startsWith( "org.springframework" ) ) {
{code}

By checking the class by name, it misses the case of a subclass of a Spring transaction manager (e.g. org.codehaus.groovy.grails.orm.hibernate.GrailsHibernateTransactionManager which extends org.springframework.orm.hibernate3.HibernateTransactionManager.)

It would have saved me some headache and it will save me a few lines of code if this code checks superclasses as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira