[jboss-jira] [JBoss JIRA] (JBJCA-1008) Assert.fail() cannot be surrounded with a try-catch block which catches a general Throwable

[Jesper Pedersen (JIRA)]

     [ https://issues.jboss.org/browse/JBJCA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesper Pedersen resolved JBJCA-1008.
------------------------------------

    Resolution: Done


Thanks for the patch !
                
> Assert.fail() cannot be surrounded with a try-catch block which catches a general Throwable
> -------------------------------------------------------------------------------------------
>
>                 Key: JBJCA-1008
>                 URL: https://issues.jboss.org/browse/JBJCA-1008
>             Project: IronJacamar
>          Issue Type: Bug
>          Components: Test suite
>    Affects Versions: 1.0.15.Final, 1.1.0.Beta4
>            Reporter: Ivo Studensky
>            Assignee: Ivo Studensky
>             Fix For: 1.0.16.Final, 1.1.0.Beta5
>
>         Attachments: JBJCA-1008.patch
>
>
> In IJ test suite there are occurrences of Assert.fail(String) surrounding with a try-catch block that catches a general Throwable. This effectively means that AssertionError produced by Assert.fail() is eaten by the following catch clause, usually quietly. And then such a test passes instead of it fails.
> Affected tests:
> {noformat}
> adapters/src/test/java/org/jboss/jca/adapters/jdbc/unit/H2SecurityDomainMultipleUsersTestCase.java
> core/src/test/java/org/jboss/jca/core/connectionmanager/connections/InterleavingTestCase.java
> deployers/src/test/java/org/jboss/jca/deployers/annotations/AnnotationsTestCase.java
> embedded/src/test/java/org/jboss/jca/embedded/unit/ShrinkWrapTestCase.java
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira