[jboss-jira] [JBoss JIRA] (WFLY-691) Horrible XML parsing error reports

[Emmanuel Hugonnet (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772063#comment-12772063 ] 

Emmanuel Hugonnet edited comment on WFLY-691 at 5/4/13 5:47 AM:
----------------------------------------------------------------

Is it still open as I don't see any closing comment on github ?
But if you look at JBossWebParsingDeploymentProcessor line 79 - 81 :
catch (XMLStreamException e) {
  throw new DeploymentUnitProcessingException(MESSAGES.failToParseXMLDescriptor(jbossWebXml, e.getLocation().getLineNumber(), e.getLocation().getColumnNumber()), e);
} 
I have added some unit tests to show that this bug is fixed in Wildfly 8.0.0.Alpha1-SNAPSHOT

                
      was (Author: ehugonnet):
    Is it still open as I don't see any closing comment on github ?
But if you look at JBossWebParsingDeploymentProcessor line 79 - 81 :
catch (XMLStreamException e) {
  throw new DeploymentUnitProcessingException(MESSAGES.failToParseXMLDescriptor(jbossWebXml, e.getLocation().getLineNumber(), e.getLocation().getColumnNumber()), e);
} 
it looks like the message is now correctly build and formatted.
                  
> Horrible XML parsing error reports
> ----------------------------------
>
>                 Key: WFLY-691
>                 URL: https://issues.jboss.org/browse/WFLY-691
>             Project: WildFly
>          Issue Type: Quality Risk
>            Reporter: Bill Burke
>             Fix For: Awaiting Volunteers
>
>
> If I make a typo in jboss-web.xml (or any other descriptor for that matter) I get really obscure errors that don't help me debug the problem.  (See below).  Each project really needs to 
> 09:39:14,132 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-8) MSC00001: Failed to start service jboss.deployment.unit."basic.war".PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit."basic.war".PARSE: Failed to process phase PARSE of deployment "basic.war"
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:121)
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1765)
> 	at org.jboss.msc.service.ServiceControllerImpl$ClearTCCLTask.run(ServiceControllerImpl.java:2291)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_26]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_26]
> 	at java.lang.Thread.run(Thread.java:680) [:1.6.0_26]
> Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: Failed to parse "/content/basic.war/WEB-INF/jboss-web.xml"
> 	at org.jboss.as.web.deployment.JBossWebParsingDeploymentProcessor.deploy(JBossWebParsingDeploymentProcessor.java:66)
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115)
> 	... 5 more
> Caused by: com.ctc.wstx.exc.WstxParsingException: Received non-all-whitespace CHARACTERS or CDATA event in nextTag().
>  at [row,col {unknown-source}]: [5,4]
> 	at com.ctc.wstx.sr.StreamScanner.constructWfcException(StreamScanner.java:606)
> 	at com.ctc.wstx.sr.StreamScanner.throwParseError(StreamScanner.java:479)
> 	at com.ctc.wstx.sr.StreamScanner.throwParseError(StreamScanner.java:464)
> 	at com.ctc.wstx.sr.BasicStreamReader.nextTag(BasicStreamReader.java:1137)
> 	at org.jboss.metadata.parser.jbossweb.ValveMetaDataParser.parse(ValveMetaDataParser.java:45)
> 	at org.jboss.metadata.parser.jbossweb.JBossWebMetaDataParser.parse(JBossWebMetaDataParser.java:155)
> 	at org.jboss.as.web.deployment.JBossWebParsingDeploymentProcessor.deploy(JBossWebParsingDeploymentProcessor.java:64)
> 	... 6 more

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira