[jboss-jira] [JBoss JIRA] (WFLY-1351) Incorrect exception handling in CoreGroupCommunicationService#handle

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774579#comment-12774579 ] 

RH Bugzilla Integration commented on WFLY-1351:
-----------------------------------------------

dereed at redhat.com made a comment on [bug 963448|https://bugzilla.redhat.com/show_bug.cgi?id=963448]

org/jboss/as/clustering/impl/CoreGroupCommunicationService#handle catches and hides any internal exceptions, and just returns null instead.

This breaks callers of CoreGroupCommunicationService when they get a null value where it's not expected (after verifying that the response was not flagged as an exception)

java.lang.NullPointerException
at org.jboss.as.clustering.lock.AbstractClusterLockSupport.lock(AbstractClusterLockSupport.java:157)

It also catches an exception from the called method, and returns it as the return value, instead of just throwing it as an exception so it can be properly returned as an exception inside JGroups' RequestCorrelator.
                
> Incorrect exception handling in CoreGroupCommunicationService#handle
> --------------------------------------------------------------------
>
>                 Key: WFLY-1351
>                 URL: https://issues.jboss.org/browse/WFLY-1351
>             Project: WildFly
>          Issue Type: Bug
>          Components: Clustering
>            Reporter: Dennis Reed
>            Assignee: Paul Ferraro
>
> org/jboss/as/clustering/impl/CoreGroupCommunicationService#handle catches and hides any internal exceptions, and just returns null instead.
> This breaks callers of CoreGroupCommunicationService when they get a null value where it's not expected (after verifying that the response was not flagged as an exception)
>     java.lang.NullPointerException
>         at org.jboss.as.clustering.lock.AbstractClusterLockSupport.lock(AbstractClusterLockSupport.java:157)
> It also catches an exception from the called method, and returns it as the return value, instead of just throwing it as an exception so it can be properly returned as an exception inside JGroups' RequestCorrelator.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira