[jboss-jira] [JBoss JIRA] (DROOLS-355) Do not import com.sun.tools.xjc in drools-core and drools-compiler

[Geoffrey De Smet (JIRA)]

Geoffrey De Smet created DROOLS-355:
---------------------------------------

             Summary: Do not import com.sun.tools.xjc in drools-core and drools-compiler
                 Key: DROOLS-355
                 URL: https://issues.jboss.org/browse/DROOLS-355
             Project: Drools
          Issue Type: Task
      Security Level: Public (Everyone can see)
    Affects Versions: 6.0.0.Final
            Reporter: Geoffrey De Smet
            Assignee: Mario Fusco


By importing com.sun.tools.xjc, 3 problems arise:

* OSGi and Karaf trip over it.
{code}
[WARNING] No export found to match com.sun.tools.xjc (imported by mvn:org.drools/drools-core/6.0.0.Final)
{code}

* JDK 9 will break any java app that uses com.sun.* classes. See Mark Reinhold's Jigsaw presentation at devoxxBE 2013.

* IBM JDK's etc don't have com.sun.* classes. Why don't they trip over this?

Why do we have those imports in the first place? Looks like code for old JAXB code - which is hopefully stale now.

Where do we use it?

{code}
Targets
    String 'com.sun.tools.xjc'
Found usages  (38 usages found)
    drools-compiler  (7 usages found)
        /home/gdesmet/projects/jboss/droolsjbpm/drools/drools-compiler  (1 usage found)
            pom.xml  (1 usage found)
                (246: 15) com.sun.tools.xjc.*;resolution:=optional,
        org.drools.compiler.builder.impl  (1 usage found)
            KnowledgeBuilderFactoryServiceImpl.java  (1 usage found)
                (18: 8) import com.sun.tools.xjc.Options;
        org.drools.compiler.runtime.pipeline.impl  (5 usages found)
            DroolsJaxbHelperProviderImpl.java  (5 usages found)
                (77: 8) import com.sun.tools.xjc.BadCommandLineException;
                (78: 8) import com.sun.tools.xjc.ErrorReceiver;
                (79: 8) import com.sun.tools.xjc.ModelLoader;
                (80: 8) import com.sun.tools.xjc.Options;
                (81: 8) import com.sun.tools.xjc.model.Model;
    drools-core  (2 usages found)
        org.drools.core.builder.conf.impl  (2 usages found)
            JaxbConfigurationImpl.java  (2 usages found)
                (28: 8) import com.sun.tools.xjc.Language;
                (34: 8) import com.sun.tools.xjc.Options;
    kie-internal  (6 usages found)
        /home/gdesmet/projects/jboss/droolsjbpm/droolsjbpm-knowledge/kie-internal  (1 usage found)
            pom.xml  (1 usage found)
                (27: 15) com.sun.tools.xjc;resolution:=optional,
        org.kie.internal.builder  (3 usages found)
            JaxbConfiguration.java  (1 usage found)
                (23: 8) import com.sun.tools.xjc.Options;
            KnowledgeBuilderFactory.java  (1 usage found)
                (24: 8) import com.sun.tools.xjc.Options;
            KnowledgeBuilderFactoryService.java  (1 usage found)
                (24: 8) import com.sun.tools.xjc.Options;
        org.kie.internal.builder.help  (2 usages found)
            DroolsJaxbHelperProvider.java  (1 usage found)
                (29: 8) import com.sun.tools.xjc.Options;
            KnowledgeBuilderHelper.java  (1 usage found)
                (30: 8) import com.sun.tools.xjc.Options;
    knowledge-api  (8 usages found)
        org.drools.builder  (3 usages found)
            JaxbConfiguration.java  (1 usage found)
                (21: 8) import com.sun.tools.xjc.Options;
            KnowledgeBuilderFactory.java  (1 usage found)
                (24: 8) import com.sun.tools.xjc.Options;
            KnowledgeBuilderFactoryService.java  (1 usage found)
                (24: 8) import com.sun.tools.xjc.Options;
        org.drools.builder.help  (3 usages found)
            DroolsJaxbHelperProvider.java  (1 usage found)
                (29: 8) import com.sun.tools.xjc.Options;
            KnowledgeBuilderHelper.java  (2 usages found)
                (32: 8) import com.sun.tools.xjc.Language;
                (33: 8) import com.sun.tools.xjc.Options;
        org.drools.impl  (1 usage found)
            KnowledgeBuilderFactoryServiceImpl.java  (1 usage found)
                (16: 8) import com.sun.tools.xjc.Options;
        org.drools.impl.adapters  (1 usage found)
            JaxbConfigurationAdapter.java  (1 usage found)
                (3: 8) import com.sun.tools.xjc.Options;

{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira