[jboss-jira] [JBoss JIRA] (WFLY-2589) ReadTransformedResourceOperation should set include-defaults=false when calling read-resource

[Jeff Mesnil (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927500#comment-12927500 ] 

Jeff Mesnil edited comment on WFLY-2589 at 11/29/13 2:35 AM:
-------------------------------------------------------------

I remember mentioning that when I refactored the messaging subsystem transformers.

The new attributes that I added were reaching the legacy version with the default value set. At first, I thought about setting include-defaults to false when :read-resource is called by ReadTransformedResourceOperation but changed my mind on further notice.

The resources are resolving every attributes and uses the default value if they are not set. If we do not include the default values when transforming the resources, we let the legacy versions resolve the attribute based on its own default value, not the one from the current version. That could lead to issues if such a value change between versions.

I preferred to handle that explicitly when transforming the resources.
For example, for new attributes, I discard them if they are undefined or set to the default value and reject them if they have any other value.

                
      was (Author: jmesnil):
    I remember mentioning that when I refactored the messaging subsystem transformers.

The new attributes that I added were reaching the legacy version with the default value set. At first, I thought about setting include-defaults to false when :read-resource is called by ReadTransformedResourceOperation but changed my mind on further notice.

The resources are resolving every attributes and uses the default value if they are not set. If we do not include the default values when transforming the resources, we let the legacy versions resolve the attribute based on its own default value, not the one from the current version. That could lead to issues if such a value change between versions.

I preferred to handle tha
                  
> ReadTransformedResourceOperation should set include-defaults=false when calling read-resource
> ---------------------------------------------------------------------------------------------
>
>                 Key: WFLY-2589
>                 URL: https://issues.jboss.org/browse/WFLY-2589
>             Project: WildFly
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Domain Management
>    Affects Versions: 8.0.0.Beta1
>            Reporter: Kabir Khan
>            Assignee: Kabir Khan
>
> This needs further investigation, but it seems to mean that we have a lot of ModelFixers used in the wrong situation. i.e. the when transforming resources, attributes that should be undefined reach the transformers as defined with the default value set instead.
> This needs a bit of thinking about [~jmesnil] mentioned this a few weeks ago as well. I'd like to see if he remembers before fixing

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira