[jboss-jira] [JBoss JIRA] (WFLY-2215) WorkManagerService does not start work manager

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12809437#comment-12809437 ] 

David Lloyd commented on WFLY-2215:
-----------------------------------

Every service in the container *must* be symmetrical.  This means that if you stop and start the service again, when start completes, the service will be at exactly the same level of usability that it was before it was stopped.  In other words, all work done in stop must undo the work done in start (nothing more, nothing less).

Furthermore, your requirement "start() should invoke WorkManager.cancelShutdown()" is wrong.  The stop() method should not complete until the work manager has completed shutdown.  Use asynchronous stop for this if necessary.
                
> WorkManagerService does not start work manager
> ----------------------------------------------
>
>                 Key: WFLY-2215
>                 URL: https://issues.jboss.org/browse/WFLY-2215
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: JCA
>    Affects Versions: 8.0.0.Beta1
>            Reporter: Bartosz Baranowski
>            Assignee: Stefano Maestri
>             Fix For: 8.0.0.Beta1
>
>
> WorkManagerService does not start/restart WorkManager
> https://github.com/wildfly/wildfly/blob/master/connector/src/main/java/org/jboss/as/connector/services/workmanager/WorkManagerService.java#L76
> WorkManager is set in constructor. In stop method, WorkManager.shutdown() is called. start() should invoke WorkManager.cancelShutdown().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira