[jboss-jira] [JBoss JIRA] (DROOLS-140) KIE module injection through CDI does not work in container

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/DROOLS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12823829#comment-12823829 ] 

RH Bugzilla Integration commented on DROOLS-140:
------------------------------------------------

Marek Winkler <mwinkler at redhat.com> made a comment on [bug 955193|https://bugzilla.redhat.com/show_bug.cgi?id=955193]

(In reply to Kanchan Desai from comment #15)
> Hi Marek,
> 
> Can you please share some more info on this bug, probably the fix and the
> result.

Hi Kanchan,

in general, this issue has been caused by Drools resource loading which was not suitable for the JBoss EAP application server environment. EAP uses JBoss VFS and Drools resource loading mechanism had problems with that.

The reason was that Drools attempts to locate every KieModule on the classpath by looking for all resources called 'META-INF/kmodule.xml'. For every such resource found, it needs also to locate pom.properties (or pom.xml) file. 

The problem was that path of pom.properties is not known in advance (it is located in a relative path to kmodule.xml, such as 'maven/<groupId>/<artifactId>/pom.properties'), where <groupId> and <artifactId> are directories named according to the maven artifact they are part of, therefore you cannot use standard java resource loading mechanism to locate it. Drools accessed the filesystem (either a jar, or physical filesystem) hosting the kmodule.xml resource to determine the location of pom.properties, which did not work in case of JBoss VFS.

Mario has fixed that, in case you needed more technical details about the fix, he would give you the most accurate information.

The result is working CDI injection of Drools KieBase and KieSession with EAP. The attached reproducer web app works now when deployed to EAP (it defines a CDI bean which is able to inject a KieSession defined in kmodule.xml).
                
> KIE module injection through CDI does not work in container
> -----------------------------------------------------------
>
>                 Key: DROOLS-140
>                 URL: https://issues.jboss.org/browse/DROOLS-140
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Mario Fusco
>            Assignee: Mario Fusco
>             Fix For: 6.0.0.CR1
>
>
> Description of problem:
> Injection of KIE module through CDI fails on JBoss EAP 6.0/6.1 due to wrong processing of resource URI when loading pom.properties in ClasspathKieProject.
> Version-Release number of selected component (if applicable):
> BRMS 6.0.0.Beta1
> EAP 6.0, 6.1.ER4
> How reproducible:
> Deploy the attached reproducer WAR. Deployment fails, server.log contains the following error (see attachment for all errors in log):
> 15:40:29,923 INFO  [stdout] (MSC service thread 1-2) kmodules: vfs:/content/kie-cdi-war-web-app-1.0.0-SNAPSHOT.war/WEB-INF/lib/kie-cdi-war-kie-module-1.0.0-SNAPSHOT.jar/META-INF/kmodule.xml
> 15:40:29,939 ERROR [org.drools.compiler.kie.builder.impl.ClasspathKieProject] (MSC service thread 1-2) Unable to load pom.properties from/content/kie-cdi-war-web-app-1.0.0-SNAPSHOT.war/WEB-INF/lib/kie-cdi-war-kie-module-1.0.0-SNAPSHOT.jar as jarPath cannot be found
> /content/kie-cdi-war-web-app-1.0.0-SNAPSHOT.war/WEB-INF/lib/kie-cdi-war-kie-module-1.0.0-SNAPSHOT.jar
> The first log line shows that ClasspathKieProject located kmodule.xml at URL starting with protocol 'vfs:'. Later, in method fixURLFromKProjectPath, the protocol prefix is removed, leading to URL /content/kie-cdi-war-web-app-1.0.0-SNAPSHOT.war/WEB-INF/lib/kie-cdi-war-kie-module-1.0.0-SNAPSHOT.jar which now references absolute path which is wrong.
> Steps to Reproduce:
> 1. Deploy attached reproducer WAR on EAP 6.
> 2. Watch server.log for deployment errors.
>   
> Actual results:
> Deployment fails due to failed injection.
> Expected results:
> Application deploys successfully and writes INFO message into server.log.
> Additional info:
> This issue blocks further testing if KIE module injection through CDI. It also renders the CDI feature unusable in real environment (e.g. some web or EJB container with CDI).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira