[jboss-jira] [JBoss JIRA] (WFLY-2051) CLI write attribute dialog for string value should enclose value in generated command to double quotes

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803792#comment-12803792 ] 

RH Bugzilla Integration commented on WFLY-2051:
-----------------------------------------------

Chao Wang <chaowan at redhat.com> made a comment on [bug 988283|https://bugzilla.redhat.com/show_bug.cgi?id=988283]

Issue exists in wildfly as well, and also see this with normal CLI write-attribute operation for attributes like STRING type and expression-allowed => true, 
Example: /interface=management:write-attribute(name=inet-address,value=${jboss.bind.address.management:127.0.0.1})

>From https://github.com/wildfly/wildfly/blob/master/cli/src/main/java/org/jboss/as/cli/ArgumentValueConverter.java?source=c#L71

toSet = ModelNode.fromString(value); This returns 'IllegalArgumentException: Invalid character: $' then '$' is set by ArgumentValueCallbackHandler

Create an upstream issue as well https://issues.jboss.org/browse/WFLY-2051
                
> CLI write attribute dialog for string value should enclose value in generated command to double quotes
> ------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-2051
>                 URL: https://issues.jboss.org/browse/WFLY-2051
>             Project: WildFly
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 8.0.0.Alpha4
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>
> {noformat}
> Wildfly issue for https://bugzilla.redhat.com/show_bug.cgi?id=988283
> String value entered in write attribute dialog is written to command without double quotes, which is wrong in many cases
> Eg. when user enteres in dialog value ${jboss.bind.address:127.0.0.1}
> following command is generated:
> /subsystem=webservices/:write-attribute(name=wsdl-host,value=${jboss.bind.address:127.0.0.1})
> Correctly should be generated command 
> /subsystem=webservices/:write-attribute(name=wsdl-host,value="${jboss.bind.address:127.0.0.1}")
> 1. start AS
>   ./bin/standalone.sh
> 2. start CLI GUI 
>   ./bin/jboss-cli.sh --gui &
> 3. click on node subsystem=webservices of /
> 4. right click on wsdl-host and select write-attribute
> 5. enter value ${jboss.bind.address:127.0.0.1} and click OK
> 6. submit generated command
> 7. reload node
>   click on node subsystem=webservices of / (close node)
>   click on node subsystem=webservices of / (open node)
> Result is wsdl-host=$ instead of wsdl-host=${jboss.bind.address:127.0.0.1}
> Workaround: in dialog box enclose the value in double quotes
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira