[jboss-jira] [JBoss JIRA] (WFLY-826) ModuleClassLoader breaks Aspect-J non-load-time-weaving aspects

[David Lloyd (JIRA)]

     [ https://issues.jboss.org/browse/WFLY-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Lloyd resolved WFLY-826.
------------------------------

    Resolution: Rejected


I'm not going to accept this issue.  It seems like a shortcoming in AspectJ that it assumes a flat classpath.  This is not something that can be fixed with a wave of a wand, and anyway if JDK9 comes along with modules, it's likely to just break for good on all applications.
                
> ModuleClassLoader breaks Aspect-J non-load-time-weaving aspects 
> ----------------------------------------------------------------
>
>                 Key: WFLY-826
>                 URL: https://issues.jboss.org/browse/WFLY-826
>             Project: WildFly
>          Issue Type: Bug
>          Components: Class Loading
>         Environment: Windows 7
>            Reporter: Jarkko Rantavuori
>            Assignee: David Lloyd
>         Attachments: MyMethodTrace.java, MyMethodTraceAspect.java, spring-app-aop-datasource-1.0.0-BUILD-SNAPSHOT.war, spring-mvc-aop-datasource-app.zip
>
>
> Special measures need to be taken for load-time-weaving with aspects, but using them without load-time weaving works normally OOB. However, if this kind of Spring configuration is used:
>     <!-- Test to get a data source -->
>     <jee:jndi-lookup id="dataSource" jndi-name="jboss/datasources/ExampleDS"/>
>     <!-- AOP part -->
>     <bean id="methodTraceAspect" class="fi.eis.applications.jboss.poc.gemini.spring.aop.support.api.MyMethodTraceAspect"/>
>     <aop:aspectj-autoproxy />
>     <!-- end AOP -->
>     <bean class="fi.eis.applications.controllers.HomeController">
>         <constructor-arg ref="dataSource" />
>     </bean>
> JBoss tries to use methodTraceAspect also on the data source. Data source is loaded by ModuleClassLoader that in has only visibility to org.jboss.jca.adapters* classes (confirmed with a debugger), so it cannot find the aspect class anymore, making aspect-j throw org.aspectj.weaver.reflect.ReflectionWorld$ReflectionWorldException: warning can't determine implemented interfaces of missing type
> fi.eis.applications.jboss.poc.gemini.spring.aop.support.api.MyMethodTraceAspect [Xlint:cantFindType].
> This has large problems in bigger applications, where general AOP pointcuts are used - no jboss-module stuff can be used as beans, anywhere. I'm aware of no workaround for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira