[jboss-jira] [JBoss JIRA] (WFLY-3173) Default number of DIST owners is too conservative

Radoslav Husar (JIRA) issues at jboss.org
Thu Apr 3 13:45:13 EDT 2014


    [ https://issues.jboss.org/browse/WFLY-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12959054#comment-12959054 ] 

Radoslav Husar edited comment on WFLY-3173 at 4/3/14 1:45 PM:
--------------------------------------------------------------

Also in the model itself:

{code}
    static final SimpleAttributeDefinition OWNERS = new SimpleAttributeDefinitionBuilder(ModelKeys.OWNERS, ModelType.INT, true)
            .setXmlName(Attribute.OWNERS.getLocalName())
            .setAllowExpression(true)
            .setFlags(AttributeAccess.Flag.RESTART_ALL_SERVICES)
            .setDefaultValue(new ModelNode().set(2))
            .setValidator(new IntRangeValidator(1, true, true))
            .build()
    ;
{code}

We explicitly specify the value (4) so we don't rely on a default, thus the transformer is *not needed*.
                
      was (Author: rhusar):
    Also in the model itself:

{code}
    static final SimpleAttributeDefinition OWNERS = new SimpleAttributeDefinitionBuilder(ModelKeys.OWNERS, ModelType.INT, true)
            .setXmlName(Attribute.OWNERS.getLocalName())
            .setAllowExpression(true)
            .setFlags(AttributeAccess.Flag.RESTART_ALL_SERVICES)
            .setDefaultValue(new ModelNode().set(2))
            .setValidator(new IntRangeValidator(1, true, true))
            .build()
    ;
{code}

Thus, the transformer is *not needed*.
                  
> Default number of DIST owners is too conservative
> -------------------------------------------------
>
>                 Key: WFLY-3173
>                 URL: https://issues.jboss.org/browse/WFLY-3173
>             Project: WildFly
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: Clustering
>    Affects Versions: 8.0.0.Final
>            Reporter: Paul Ferraro
>            Assignee: Radoslav Husar
>             Fix For: 8.0.1.Final
>
>
> WildFly uses DIST by default using 4 owners, which is too conservative.  I think we should lower this default value to 2, which is Infinispan's default value.  We'll get a nice performance bump too.
> Don't forget to create transformers to handle the default value change for old model versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jboss-jira mailing list