[jboss-jira] [JBoss JIRA] (WFLY-832) module.xml schema checking should log errors when it encounters them

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12962899#comment-12962899 ] 

David Lloyd commented on WFLY-832:
----------------------------------

Testing with a simple case, I got this error:

{noformat}
Exception in thread "main" org.jboss.modules.ModuleLoadException: Error loading module from /home/david/src/java/wildfly/build/target/wildfly-8.0.1.Final-SNAPSHOT/modules/system/layers/base/org/jboss/as/standalone/main/module.xml
	at org.jboss.modules.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:155)
	at org.jboss.modules.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:132)
	at org.jboss.modules.LocalModuleFinder$1.run(LocalModuleFinder.java:154)
	at org.jboss.modules.LocalModuleFinder$1.run(LocalModuleFinder.java:148)
	at java.security.AccessController.doPrivileged(Native Method)
	at org.jboss.modules.LocalModuleFinder.findModule(LocalModuleFinder.java:148)
	at org.jboss.modules.ModuleLoader.findModule(ModuleLoader.java:455)
	at org.jboss.modules.ModuleLoader.loadModuleLocal(ModuleLoader.java:358)
	at org.jboss.modules.ModuleLoader.preloadModule(ModuleLoader.java:305)
	at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:238)
	at org.jboss.modules.Main.main(Main.java:385)
Caused by: org.jboss.modules.xml.XmlPullParserException: end tag name </resouruces> must match start tag name <resources> from line 32 (position: TEXT seen ...<resources>\n    </resouruces>... @33:18) 
	at org.jboss.modules.xml.MXParser.parseEndTag(MXParser.java:1686)
	at org.jboss.modules.xml.MXParser.nextImpl(MXParser.java:1128)
	at org.jboss.modules.xml.MXParser.next(MXParser.java:1090)
	at org.jboss.modules.xml.MXParser.nextTag(MXParser.java:1077)
	at org.jboss.modules.ModuleXmlParser.parseResources(ModuleXmlParser.java:563)
	at org.jboss.modules.ModuleXmlParser.parseModuleContents(ModuleXmlParser.java:394)
	at org.jboss.modules.ModuleXmlParser.parseDocument(ModuleXmlParser.java:219)
	at org.jboss.modules.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:153)
	... 10 more
{noformat}

I think perhaps the newer pull parser might be more strict about this.  If JDBC driver errors however are still not being logged, then it might be a bug in the driver loading code, where it doesn't log exceptions properly.
                
> module.xml  schema checking should log errors when it encounters them
> ---------------------------------------------------------------------
>
>                 Key: WFLY-832
>                 URL: https://issues.jboss.org/browse/WFLY-832
>             Project: WildFly
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Server
>            Reporter: Tom Fonteyne
>            Assignee: David Lloyd
>            Priority: Minor
>
> When defining a JDBC driver, we made a syntax error in the module.xml
> <resources>
>   <resource-root path="driver.jar"/>
> </resoruces>
> Note the misspelled closing tag "</resoruces>"
> The driver did not get loaded (logically) but no error message was logged in server.log about this

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira