[jboss-jira] [JBoss JIRA] (WFLY-3277) Fix for JAVASERVERFACES-3189 causes memory leak

[Farah Juma (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964481#comment-12964481 ] 

Farah Juma commented on WFLY-3277:
----------------------------------

Because the JSF implementation module dependency is added to every deployment, one ConfigureListener gets registered for every deployment even if it doesn't use JSF (the ConfigureListener is defined in the jsf_core.tld file in the jsf-impl.jar). For apps that use JSF, a second ConfigureListener ends up getting added by Mojarra if the app doesn't contain a mapping of FacesServlet in its web.xml file (this is because of a [workaround | https://issues.jboss.org/browse/WFLY-2594?focusedCommentId=12946617&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12946617] for a GlassFish issue that was added to Mojarra 2.x).

I found that the memory leak only affects non-JSF apps though. As discussed with Tomaz, one way to work around the issue is to have the JSF subsystem remove the ConfigureListener from the TLD metadata unless the app has a mapping of FacesServlet in its web.xml. I tried this out (see [here| https://github.com/fjuma/wildfly/commit/fc9157ffc734960f20feb2262ea8c05095479391]) and it does work. However, I think I just found a better way to fix this in ConfigureListener by making sure that appropriate clean up is done when ConfigureListener.contextInitialized() is called for an app that doesn't use JSF. I've created the following upstream issue and if my fix looks good to the Mojarra team, I can apply it to our fork:

https://java.net/jira/browse/JAVASERVERFACES-3260
                
> Fix for JAVASERVERFACES-3189 causes memory leak
> -----------------------------------------------
>
>                 Key: WFLY-3277
>                 URL: https://issues.jboss.org/browse/WFLY-3277
>             Project: WildFly
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: JSF
>    Affects Versions: 8.1.0.CR1
>            Reporter: Tomaz Cerar
>            Assignee: Farah Juma
>            Priority: Blocker
>             Fix For: 8.1.0.Final
>
>         Attachments: capedwarf-test.war
>
>
> Running capedwarf testsuite we found out that after upgrade to 8.1.0.CR1 testsuite does not complete as server dies with OOM.
> I traced problem down to this commit: https://github.com/jboss/mojarra/commit/d0f9f873dc0f99047a0a5031631d091fa65b6b33
> reverting it fixes the problem.
> For what is worth, I think original problem comes from fact that we somehow register two ConfigureListeners for every deployment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira