[jboss-jira] [JBoss JIRA] (WFLY-3710) Break close association of AppclientXml with WildFly-Core

[Darran Lofthouse (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990423#comment-12990423 ] 

Darran Lofthouse commented on WFLY-3710:
----------------------------------------

Looks like we also need to go one step further, whilst AppClientXml parses the 'server' element it only supports a subset of it's content.  For better or worse the schemas are the document that describes the XML we support - deliberately rejecting configuration that is valid against the schema is not good.



> Break close association of AppclientXml with WildFly-Core
> ---------------------------------------------------------
>
>                 Key: WFLY-3710
>                 URL: https://issues.jboss.org/browse/WFLY-3710
>             Project: WildFly
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Application Client, Domain Management
>            Reporter: Darran Lofthouse
>            Assignee: Darran Lofthouse
>             Fix For: 9.0.0.Beta1
>
>
> AppClientXml is written on the basis that it is in the same project as the remaining domain management parsers, as an example it is dependent on calling certain version specific vault methods.
> Changes will also be needed to wildfly-core but any access to parsers in wildfly-core should be switched to agreed entry points that will be maintained by compatibility.
> As an example this block: -
> {code}
>         if (element == Element.VAULT) {
>             switch (namespace) {
>                 //Less than 1.1 does not end up in this method
>                 case DOMAIN_1_1:
>                 case DOMAIN_1_2:
>                 case DOMAIN_1_3:
>                 case DOMAIN_1_4:
>                 case DOMAIN_1_5:
>                 case DOMAIN_2_0:
>                 case DOMAIN_2_1: {
>                     parseVault_1_1(reader, address, namespace, list);
>                     break;
>                 }
>                 default: {
>                     parseVault_3_0(reader, address, namespace, list);
>                 }
>             }
> {code}
> Should be replaced with a call to parseVault(), the parseVault() method will then be responsible for identifying the correct version.
> Changes should also be made to AppClientXml to make it compatible with multiple major versions in use concurrently for jboss-as-config - otherwise this class is seriously likely to be missed again for all further updates.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)