[jboss-jira] [JBoss JIRA] (DROOLS-546) FactType.get/set should throw specific exception (not NPE) for unknown fields

Benoit Voisin (JIRA) issues at jboss.org
Wed Aug 27 12:59:00 EDT 2014


     [ https://issues.jboss.org/browse/DROOLS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benoit Voisin updated DROOLS-546:
---------------------------------
    Description: 
*WARNING : the committed fix does not implement the behavior intended by the title or description : the code now simply ignore without any error the unknown field*

factType.get(instance, "unknownField") is currently throwing an NPE. This gives improper information to the user/developper.
I propose that it throws a new UnknownFactFieldException giving improved information giving good hints for debugging or enabling specific exception management.

See pull request for test-case and proposed fix

  was:
factType.get(instance, "unknownField") is currently throwing an NPE. This gives improper information to the user/developper.
I propose that it throws a new UnknownFactFieldException giving improved information giving good hints for debugging or enabling specific exception management.

See pull request for test-case and proposed fix



> FactType.get/set should throw specific exception (not NPE) for unknown fields
> -----------------------------------------------------------------------------
>
>                 Key: DROOLS-546
>                 URL: https://issues.jboss.org/browse/DROOLS-546
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 6.1.0.CR1
>            Reporter: Benoit Voisin
>            Assignee: Mario Fusco
>             Fix For: 6.1.0.Final, 6.2.0.Beta1
>
>
> *WARNING : the committed fix does not implement the behavior intended by the title or description : the code now simply ignore without any error the unknown field*
> factType.get(instance, "unknownField") is currently throwing an NPE. This gives improper information to the user/developper.
> I propose that it throws a new UnknownFactFieldException giving improved information giving good hints for debugging or enabling specific exception management.
> See pull request for test-case and proposed fix



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)


More information about the jboss-jira mailing list