[jboss-jira] [JBoss JIRA] (JGRP-1893) ENCRYPT: Thread safety issues during key changes

[Tero Leppikangas (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025148#comment-13025148 ] 

Tero Leppikangas commented on JGRP-1893:
----------------------------------------

Although the thread safety issue is quite obvious, it is extremely rare and it only comes to play when using ENCRYPT with changing ciphers.The ENCRYPT has far more serious issues related to the cipher change mechanism so we currently removed ENCRYPT from our stack.
For me it is ok to resolve this issue with won't fix.

> ENCRYPT: Thread safety issues during key changes
> ------------------------------------------------
>
>                 Key: JGRP-1893
>                 URL: https://issues.jboss.org/browse/JGRP-1893
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Tero Leppikangas
>            Assignee: Bela Ban
>             Fix For: 3.6.2
>
>
> For symmetric encryption, ENCRYPT has members with shared state: secret key, version and ciphers. In order for to provide consistent state between different threads accessing these members, they should be synchronized.
> I have implemented one solution by wrapping the state in separate object which can be found here:
> https://github.com/tepitebson/JGroups/tree/ENCRYPT_Thread_safety
> I also have replaced the WeakHashMap holding the previous keys with Cache in google's guava library so my solution probably is not suitable for an official solution.



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)