[jboss-jira] [JBoss JIRA] (WFLY-2783) EmbeddedContainerConfiguration does not validate correctly

[Tommy Tynjä (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12942558#comment-12942558 ] 

Tommy Tynjä commented on WFLY-2783:
-----------------------------------

The proposed code change causes a failure in org.jboss.as.arquillian.container.embedded.CdiTestCase in CI where the EmbeddedServerFactory fails to load the VFS module
{quote}
java.lang.RuntimeException: JBAS011137: Cannot load module org.jboss.vfs from: local module loader @48df550d
	...
Caused by: org.jboss.modules.ModuleNotFoundException: org.jboss.vfs:main
	at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:240)
	at org.jboss.as.embedded.EmbeddedServerFactory.setupVfsModule(EmbeddedServerFactory.java:201)
{quote}
	
That test seems to fail even with the modifications reverted. What is the current status of the embedded container? Any pointers on how to resolve this?
                
> EmbeddedContainerConfiguration does not validate correctly
> ----------------------------------------------------------
>
>                 Key: WFLY-2783
>                 URL: https://issues.jboss.org/browse/WFLY-2783
>             Project: WildFly
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 8.0.0.CR1
>            Reporter: Markus von Rüden
>            Priority: Minor
>
> I experimented a bit with arquillian and the embedded wildfly container.
> However, durinng startup I am getting this exception: 
> {code}
>     java.lang.RuntimeException: JBAS011137: Cannot load module org.jboss.vfs from: local module loader @3a55b9b (finder: local module finder @5d211efb (roots: /home/username/dev/arquillian-tutorial/null/modules))
> {code}
> So I took a deeper look at class 
> org.jboss.as.arquillian.container.embedded.EmbeddedContainerConfiguration located in "wildfly/arquillian/embedded"
> The validate method there seems to have a validation problem:
> {code}
> @Override
>     public void validate() throws ConfigurationException {
>         super.validate();
>         Validate.configurationDirectoryExists(jbossHome, "jbossHome '" + jbossHome + "' must exist");
>         Validate.configurationDirectoryExists(jbossHome, "modulePath '" + modulePath + "' must exist");
>         Validate.configurationDirectoryExists(jbossHome, "bundlePath '" + bundlePath + "' must exist");
>     }
> {code}
> It checks jbossHome three times. But I assume it should check jbossHome, bundleHome and moduleHome instead.
> I am not sure if the Exception and the validation-implementation are associated with each other in any way, but the validate() method looks wrong to me :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira