[jboss-jira] [JBoss JIRA] (WFLY-2921) Wrong condition statement in NetworkUtils#formatAddress(InetSocketAddress)

[Ted Won (JIRA)]

Ted Won created WFLY-2921:
-----------------------------

             Summary: Wrong condition statement in NetworkUtils#formatAddress(InetSocketAddress)
                 Key: WFLY-2921
                 URL: https://issues.jboss.org/browse/WFLY-2921
             Project: WildFly
          Issue Type: Bug
      Security Level: Public (Everyone can see)
    Affects Versions: 8.0.0.Final
            Reporter: Ted Won
            Priority: Minor


It seems there is a wrong condition statement of formatAddress(InetSocketAddress inet) in the class org.jboss.as.network.NetworkUtils.
https://github.com/wildfly/wildfly/blob/master/network/src/main/java/org/jboss/as/network/NetworkUtils.java

This method returns "ipAddress:port", but expected to "hostname:port".

public static String formatAddress(InetSocketAddress inet)
...
// As-is
if(inet.isUnresolved()){
            result.append(inet.getHostName());

// Expected to reversely: 
if(!inet.isUnresolved()){
            result.append(inet.getHostName());
...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira