[jboss-jira] [JBoss JIRA] (WFLY-2947) DefaultOperationDescriptionProvider uses incorrect call to create reply parameter description

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12945505#comment-12945505 ] 

Brian Stansberry commented on WFLY-2947:
----------------------------------------

In the more commonly used code path it calls AttributeDefinition.addOperationParameterDescription(...) which in turn calls descriptionResolver.getOperationParameterDescription(). So fixing this is a bit more complex. AttributeDefinition itself doesn't expose the necessary API for distinguishing reply elements from operation parameters.

There's also the issue of distinguishing deprecation descriptions for the two cases. ResourceDescriptionResolver itself doesn't expose a method for getting reply parameter deprecation data.

I was originally planning on fixing this quickly, but given how the above expands the scope of the task considerably, I'm going to wait. It's not particularly urgent; it would only cause problems if an operation had a parameter "foo" and a reply element also named "foo" and the description text needed to be different between the two or the deprecation data needed to be different.
                
> DefaultOperationDescriptionProvider uses incorrect call to create reply parameter description
> ---------------------------------------------------------------------------------------------
>
>                 Key: WFLY-2947
>                 URL: https://issues.jboss.org/browse/WFLY-2947
>             Project: WildFly
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Domain Management
>    Affects Versions: 8.0.0.Final
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>
> When creating reply descriptions, DefaultOperationDescriptionProvider calls attributeDescriptionResolver.getOperationParameterDescription instead of attributeDescriptionResolver.getOperationReplyValueTypeDescription.
> A fix needs to not break compatibility for existing users of the incorrect behavior; i.e. call the correct method in a try block, catch any MissingResourceException, and if caught call the incorrect method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira